Closed Bug 373926 Opened 18 years ago Closed 17 years ago

Time-tracking and attachment tables look too different

Categories

(Bugzilla :: User Interface, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: ycombarnous, Assigned: guy.pyrzak)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2 Build Identifier: Even the header do not have the same grey level. Couldn't these tables implement some of the same CSS elements ? Reproducible: Always Steps to Reproduce: 1. 2. 3.
Version: unspecified → 3.0
Blocks: bz-show_bug
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
The hardcoded align and bgcolor attributes on the tables need to be taken out as they interfere with skining. Also, the time tracking table should have an id attribute so that it can be styled from the skin in the same manner as the attachments. Furthermore, I think that both of these two tables should be enclosed in a fieldset tag with a legend so that they share the same appearence as the elements above (it is debatable semantically for the attachments as there are no fields in there, but the "related actions" list is in a fieldset with no fields)
The css ids are done via bug 345674. They still look different though. Very simple fix can be done via css.
Assignee: ui → guy.pyrzak
Attached patch Patch v1 (deleted) — Splinter Review
Attachment #301360 - Flags: review?(mkanat)
Comment on attachment 301360 [details] [diff] [review] Patch v1 Sure, looks good to me!
Attachment #301360 - Flags: review?(mkanat) → review+
Status: NEW → ASSIGNED
Flags: approval+
Target Milestone: --- → Bugzilla 3.2
Checking in skins/standard/global.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v <-- global.css new revision: 1.44; previous revision: 1.43 done Checking in skins/standard/show_bug.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/show_bug.css,v <-- show_bug.css new revision: 1.5; previous revision: 1.4 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: