Closed
Bug 377756
Opened 18 years ago
Closed 18 years ago
move property change events code to atk
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Now atk code has support for PROPERTY_CHANGED event, but it is not used in MSAA and IA2 and we do not generate it in gecko therefore I moved this code into atk entirely.
Attachment #261788 -
Flags: review?(ginn.chen)
2 compile warnings:
1)
nsDocAccessibleWrap.cpp:90: warning: unused variable ‘oldAccWrap’
nsDocAccessibleWrap.cpp:90: warning: unused variable ‘newAccWrap
2)
nsAccessibleEventData.h: In constructor ‘nsAccEvent::nsAccEvent(PRUint32, nsIAccessible*, void*)’:
nsAccessibleEventData.h:66: warning: ‘nsAccEvent::mAccessible’ will be initialized after
nsAccessibleEventData.h:62: warning: ‘void* nsAccEvent::mEventData’
nsAccessibleEventData.cpp:47: warning: when initialized here
nsAccessibleEventData.h: In constructor ‘nsAccEvent::nsAccEvent(PRUint32, nsIDOMNode*, void*)’:
nsAccessibleEventData.h:67: warning: ‘nsAccEvent::mDOMNode’ will be initialized after
nsAccessibleEventData.h:62: warning: ‘void* nsAccEvent::mEventData’
nsAccessibleEventData.cpp:53: warning: when initialized here
and I happen to find a typo in patch of Bug 377617, I'm sorry I missed it.
+nsAccTextChangeEvent::
+ nsAccTextChangeEvent(nsIAccessible *aAccessible,
+ PRInt32 aStart, PRUint32 aLength, PRBool aIsInserted):
+ nsAccEvent(::nsIAccessibleEvent::EVENT_TEXT_CHANGED, aAccessible, nsnull),
+ mStart(aStart), mLength(aLength), mIsInserted(mIsInserted)
should be mIsInserted(aIsInserted)
I'll double check this patch tomorrow.
Comment on attachment 261788 [details] [diff] [review]
patch
r=me if compile warnings are fixed.
Attachment #261788 -
Flags: review?(ginn.chen) → review+
Assignee | ||
Comment 3•18 years ago
|
||
with ginn's comments, for checking in
Attachment #261788 -
Attachment is obsolete: true
Assignee | ||
Comment 4•18 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•