Closed
Bug 380602
Opened 18 years ago
Closed 18 years ago
top left corner missing when -moz-border-radius-* is used
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Mook, Assigned: vlad)
References
()
Details
Attachments
(2 files, 1 obsolete file)
This is a spinoff from bug 379474 comment 19, and bz says is a regression from bug 368247.
See testcase - the top left corner border is missing a chunk (looks to be about 1/2 of the border width?) when border-radius-* is used, where * != topleft.
Yes, it's always the top left corner that's missing.
Tested on 20070513/trunk/win32.
|
||
Updated•18 years ago
|
Flags: blocking1.9?
|
Assignee | |
Comment 2•18 years ago
|
||
A fix. We need to use ClosePath() to get the right join if there's no radius in the top-left corner -and- no sides are being skipped/not drawn.
|
|
||
Comment 3•18 years ago
|
||
What if we did, say, skip the right side? Wouldn't the bug remain in that case?
|
|
Assignee | |
Comment 4•18 years ago
|
||
(In reply to comment #3)
> What if we did, say, skip the right side? Wouldn't the bug remain in that
> case?
No, because the code will end up drawing bottom -> left -> top in that case, and there endpoints of the shouldn't be joined.
|
|
||
Comment 5•18 years ago
|
||
Ah, I'd missed that part of the code. Very nice!
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking1.9? → blocking1.9+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #265055 -
Attachment is obsolete: true
Attachment #265055 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 6•18 years ago
|
||
Fixed by checked-in patch from bug 368247; the patch in this bug wasn't used.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•