Created by Kazushi Marukawa (jam@pobox.com) on Tuesday, May 19, 1998 3:02:14 AM PDT Additional Details : If I decide to use not shared libraries only, some makefiles under nsprpub directory made errors. I made patches for Makefiles to fix them. But I couldn't paste them here. I put my patch at "http://www.io.com/~kazushi/unix/netscape.noshared-patch" Updated by Kazushi Marukawa (jam@pobox.com) on Friday, June 12, 1998 11:42:40 PM PDT Additional Details : I decide to paste above my patch because I want to delete it. Index: nsprpub/config/rules.mk =================================================================== RCS file: /cvsroot/mozilla/nsprpub/config/rules.mk,v retrieving revision 3.5 diff -u -r3.5 rules.mk --- rules.mk 1998/05/07 07:23:49 3.5 +++ rules.mk 1998/05/19 05:47:19 @@ -84,10 +84,12 @@ else LIBRARY = $(OBJDIR)/lib$(LIBRARY_NAME)$(LIBRARY_VERSION).$(LIB_SUFFIX) +ifdef MKSHLIB ifeq ($(OS_ARCH)$(OS_RELEASE), AIX4.1) SHARED_LIBRARY = $(OBJDIR)/lib$(LIBRARY_NAME)$(LIBRARY_VERSION)_shr.a else SHARED_LIBRARY = $(OBJDIR)/lib$(LIBRARY_NAME)$(LIBRARY_VERSION).$(DLL_SUFFIX) +endif endif ifdef HAVE_PURIFY ifdef DSO_BACKEND Index: nsprpub/lib/ds/Makefile =================================================================== RCS file: /cvsroot/mozilla/nsprpub/lib/ds/Makefile,v retrieving revision 3.2 diff -u -r3.2 Makefile --- Makefile 1998/04/30 19:36:45 3.2 +++ Makefile 1998/05/19 05:47:20 @@ -97,7 +97,9 @@ export:: $(TARGETS) $(INSTALL) -m 444 $(HEADERS) $(DIST)/include $(INSTALL) -m 444 $(TARGETS) $(DIST)/lib +ifdef SHARED_LIBRARY $(INSTALL) -m 444 $(SHARED_LIBRARY) $(DIST)/bin +endif ifeq ($(MOZ_BITS),16) $(INSTALL) -m 444 $(HEADERS) $(MOZ_INCL) $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/lib Index: nsprpub/lib/libc/src/Makefile =================================================================== RCS file: /cvsroot/mozilla/nsprpub/lib/libc/src/Makefile,v retrieving revision 3.2 diff -u -r3.2 Makefile --- Makefile 1998/04/30 19:36:46 3.2 +++ Makefile 1998/05/19 05:47:22 @@ -95,7 +95,9 @@ export:: $(TARGETS) $(INSTALL) -m 444 $(TARGETS) $(DIST)/lib +ifdef SHARED_LIBRARY $(INSTALL) -m 444 $(SHARED_LIBRARY) $(DIST)/bin +endif ifeq ($(MOZ_BITS),16) $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/lib $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/bin Index: nsprpub/lib/msgc/src/Makefile =================================================================== RCS file: /cvsroot/mozilla/nsprpub/lib/msgc/src/Makefile,v retrieving revision 3.2 diff -u -r3.2 Makefile --- Makefile 1998/04/30 19:36:47 3.2 +++ Makefile 1998/05/19 05:47:25 @@ -98,7 +98,9 @@ export:: $(TARGETS) $(INSTALL) -m 444 $(TARGETS) $(DIST)/lib +ifdef SHARED_LIBRARY $(INSTALL) -m 444 $(SHARED_LIBRARY) $(DIST)/bin +endif ifeq ($(MOZ_BITS),16) $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/lib $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/bin Index: nsprpub/pr/src/Makefile =================================================================== RCS file: /cvsroot/mozilla/nsprpub/pr/src/Makefile,v retrieving revision 3.3 diff -u -r3.3 Makefile --- Makefile 1998/04/21 17:21:49 3.3 +++ Makefile 1998/05/19 05:47:35 @@ -296,7 +296,9 @@ export:: $(TARGETS) $(INSTALL) -m 444 $(TARGETS) $(DIST)/lib +ifdef SHARED_LIBRARY $(INSTALL) -m 444 $(SHARED_LIBRARY) $(DIST)/bin +endif ifeq ($(MOZ_BITS),16) $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/lib $(INSTALL) -m 444 $(TARGETS) $(MOZ_DIST)/bin Index: nsprpub/pr/tests/dll/Makefile =================================================================== RCS file: /cvsroot/mozilla/nsprpub/pr/tests/dll/Makefile,v retrieving revision 3.3 diff -u -r3.3 Makefile --- Makefile 1998/05/08 18:52:44 3.3 +++ Makefile 1998/05/19 05:47:56 @@ -58,7 +58,9 @@ TARGETS = $(SHARED_LIBRARY) $(IMPORT_LIBRARY) endif else +ifdef MKSHLIB SHARED_LIBRARY = $(OBJDIR)/libmy.$(DLL_SUFFIX) +endif TARGETS = $(SHARED_LIBRARY) endif @@ -82,9 +84,13 @@ endif export:: $(TARGETS) +ifdef SHARED_LIBRARY $(NSINSTALL) $(TARGETS) ../$(OBJDIR)/dll +endif install:: export clean:: +ifdef SHARED_LIBRARY rm -rf $(TARGETS) +endif Updated by Wan-Teh Chang (wtc@netscape.com) on Tuesday, June 16, 1998 8:33:05 PM PDT Additional Details : Accepted the bug. Thanks for the patch. I will review it and check it in. I am curious: which Unix platform do you use that doesn't have shared libraries? Updated by Wan-Teh Chang (wtc@netscape.com) on Monday, July 13, 1998 2:55:01 PM PDT Additional Details : Your fix has been checked into our internal development version of nspr. I used pretty much the patch you provided. The public Mozilla tree is in a stability code freeze right now. I will check in the fix when the code freeze is over.

I have already checked in your patch but forgot to update this bug report. Marked the bug fixed.

qa contact set to gerardok@netscape.com for applicability review against new code base

This bug has been fixed and I have verified the fix myself. Closed the bug.

NSPR now has its own Bugzilla product. Moving this bug to the NSPR product.