Closed
Bug 382293
Opened 17 years ago
Closed 17 years ago
sync maiutil code with gail/gailutil.c
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
(Keywords: access)
Attachments
(1 file)
|
(deleted),
patch
|
evan.yan
:
review+
|
Details | Diff | Splinter Review |
The maiutil is based gailutil.
But I found some differences in *_util_add_key_event_listener, *_util_remove_key_event_listener part.
I think we can change the code of maiutil to make it easier to be maintained.
Also I found a memory leak mai_util_add_global_event_listener, which was fixed in gailutil 3 years ago.
Attachment #266448 -
Flags: review?(aaronleventhal)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 266448 [details] [diff] [review]
patch
Ginn, I don't feel qualified to review this. Perhaps Evan can help?
Attachment #266448 -
Flags: review?(aaronleventhal) → review?(Evan.Yan)
Comment on attachment 266448 [details] [diff] [review]
patch
looks good.
nit:
+ info->key_event = atk_key_event_from_gdk_event_key (event);
+ info->func_data = func_data;
+ consumed = g_hash_table_foreach_steal (new_hash, notify_hf, info);
g_hash_table_destroy (new_hash);
- g_free (keyEvent);
}
+ g_free(info->key_event);
the last line can be moved up into the block.
Attachment #266448 -
Flags: review?(Evan.Yan) → review+
Attachment #266448 -
Attachment filename: 382283.diff → 382293.diff
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•