Closed
Bug 382567
Opened 17 years ago
Closed 17 years ago
Use GetNativeInterface, GetAccessibleWrap instead of CAST
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
(deleted),
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
I think using nsIAccessible::GetNativeInterface is a safer, cleaner way than NS_STATIC_CAST nsIAccessible to nsAccessibleWrap and then GetAtkObject().
And we can use
nsAccessibleWrap *accWrap = GetAccessible(aAtkObj);
instead of
nsAccessibleWrap *accWrap = NS_REINTERPTET_CAST(MaiAtkObject*, aAtkObj)->accWrap;
Attachment #266723 -
Flags: review?(surkov.alexander)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 266723 [details] [diff] [review]
patch
I like this approach. Probably you would save some code lines if you add GetAtkObject(nsIAccessible*) like GetAccessibleWrap(). But it's not worth to do. Also you removed checking of nsresult but it's safely to have it but I'm sure you know what you do :).
Attachment #266723 -
Flags: review?(surkov.alexander) → review+
There is a typo in my patch, sorry for that.
+ AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObj);
should be
+ AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObjPtr);
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•