Closed
Bug 385
Opened 26 years ago
Closed 24 years ago
GH_InitGlobalHistory called too soon
Categories
(MozillaClassic Graveyard :: XFE, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: waider, Assigned: slamm)
Details
Created by Ronan Waide (waider@waider.ie) on Wednesday, May 20, 1998 4:05:03 AM PDT
Additional Details :
GH_InitGlobalHistory is called before FE_GlobalHist is set
from the preferences file, meaning that gh_open_database
doesn't have a filename to work with. Here's a patch to
main()/mozilla-main() to fix this:
Index: cmd/xfe/mozilla.c
===================================================================
RCS file: /cvsroot/mozilla/cmd/xfe/mozilla.c,v
retrieving revision 3.5
diff -c -r3.5 mozilla.c
*** mozilla.c 1998/05/14 09:18:26 3.5
--- mozilla.c 1998/05/20 11:02:04
***************
*** 2799,2812 ****
PREF_SetDefaultCharPref("profile.directory",
fe_config_dir);
PREF_SetDefaultIntPref("profile.numprofiles", 1);
- GH_InitGlobalHistory();
-
/* SECNAV_INIT needs this defined, but
build_user_agent_string cannot
* be called until after SECNAV_INIT, so call this
simplified version.
*/
build_simple_user_agent_string(versionLocale);
fe_InstallPreferences (0);
/*
** Initialize the security library.
--- 2799,2812 ----
PREF_SetDefaultCharPref("profile.directory",
fe_config_dir);
PREF_SetDefaultIntPref("profile.numprofiles", 1);
/* SECNAV_INIT needs this defined, but
build_user_agent_string cannot
* be called until after SECNAV_INIT, so call this
simplified version.
*/
build_simple_user_agent_string(versionLocale);
fe_InstallPreferences (0);
+
+ GH_InitGlobalHistory();
/*
** Initialize the security library.
Updated by Steve Lamm (slamm@netscape.com) on Wednesday, May 20, 1998 6:43:36 PM PDT
Additional Details :
The patch looks good.
I checked it in.
Updated by Steve Lamm (slamm@netscape.com) on Wednesday, May 20, 1998 6:44:18 PM PDT
Additional Details :
Marking resolved.
Updated•26 years ago
|
Component: XFE
Comment 1•24 years ago
|
||
mid-air collision ? / bugzilla cleanup
Reopening (current State: resolved and no resolution)
Status: RESOLVED → REOPENED
Comment 2•24 years ago
|
||
marking fixed
Status: REOPENED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•