Closed Bug 3855 Opened 26 years ago Closed 26 years ago

toolbar buttons don't fit in horizontal space allocated

Categories

(Core Graveyard :: Tracking, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: hyatt)

Details

Sometime between Monday morning and Tuesday morning (i.e. during the M3 freeze), someone changed the toolbar spacing so that now the stop button gets wrapped to a second line rather than fitting with the other three toolbar buttons. This should be considered a BLOCK M3 bug because it was fine on Monday and only got changed during the freeze, and that change caused a regression and should be backed out.
Assignee: mcafee → hyatt
I notice hyatt made a lot of changes to the apprunner UI in the last day, reassigning ...
Priority: P3 → P2
Target Milestone: M3
This broke with version 1.34 of navigator.xul, when the width on line 500 was changed from 160 to 155. It needs to be 160 in order for the toolbar buttons to fit on one line. Changing it to 160 fixes the problem -- the stop button is still wrapped when the buttons are first getting laid out, but at least it snaps to its proper position when the window finally stabilizes.
Yeah, this is an example of a lousy thing we're having to do with table layout, since we don't have our own layout manager in place... the extra width looks a bit silly on Mac and Windows (which use narrower fonts), but omitting the width all together doesn't work. Just change it back to 160.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fix checked in. I don't know why the toolbars are initially drawn the wrong size; I'll file a separate bug on that (not M3).
QA Contact: 3853 → 4079
Status: RESOLVED → VERIFIED
verified in 3/19 build.
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.