do they need to die for PR2?

I would like them too, but I doubt that I will have time to do so.

I have mapped all the nsFileLocations into the nsDirectoryService. Moving this off a bit.

conrad is working in this area.

This is related to bug #44314. nsFileLocations is being entirely replaced by nsDirectoryServices. The implementation of the application level nsIDirectoryServiceProvider will fix #44314. In general, using directory services will allow all file locations to be easily customized by embedding clients. All users of nsIFileLocations have been converted to using nsIDirectoryServices and I'll be checking this in as it gets reviewed.

About to check in code this week to get rid of it.

changing to new email

re-accepted at new email

per email with Jud, changing nsbeta3+ to nsbeta3- on all "embed" keyword bugs since embedding changes will not be made in the mn6 branch. If you feel this bug fix needs to go into mn6 branch, please list the reasons/user impact/risk and nominate for rtm. Thanks.

nominating for rtm. Crasher bug 54311 showed up today in nsFileLocations - best just to get rid of it.

correcting rtm. For nominations, keyword should be rtm. Conrad, sounds like you have a patch for this? Pls get it super reviewed and change the [rtm need info] to [rtm+] for PDT to approve. Also, what is the user impact if this is not fixed? Will users run into this crash easily? Thanks.

conrad - you have attached a patch but you need to get an r= from someone and then email a superreviewer and Cc reviewers@mozilla.org to get a sr= from a super-reviewer. Otherwise pdt will not approve it.

Yes, I just got sr=alecf on the portion in mailnews.

a=hyatt on the chrome registry portion.

Nominating for rtm. Now that I have super review, can I get this checked in? At least on the trunk anyway. Besides embedding, another thing which depends on this is Shrimp.

Not needed for Shrimp at this stage. Shrimp has already branched. thanks, Vishy

rtm-, but please get this on the trunk.

All users of this are gone except for a few text apps. Once those are removed, this can be closed.

At last check the only thing still using nsFileLocations were a few cmd line test tools. They would have had to have been linked with the appfilelocprovider lib, but the fix to bug 64501 makes this uneeded. Easy to do at this point.

Ignore first patch. This patch gets rid of all users - even indirect ones. Renamed nsFileLocations files, clobbered, and built.

looks like we missed 0.8 :-(

So much for bug 38122 (eliminate nsFileSpec) :-)

But that's a different issue and will need to be fixed seperately I guess. Patch looks fine, though I'm not sure if I should r=.

r=valeski

-> mozilla0.9 :-(

super-review was requested on n.p.m.reviewers - no takers, so -> 0.9.1

sr=alecf

Code to remove refs to nsFileLocations is in. Will CVS remove dead files after clobber build with files deleted locally.

Final changes (removing files from Mac projects) checked in and files CVS removed. nsFileLocations is as dead as a door nail.