Closed
Bug 389565
Opened 17 years ago
Closed 7 years ago
Remove nsIExternalProtocolService::LoadUrl
Categories
(Firefox :: File Handling, defect)
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: sdwilsh, Assigned: emk)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-review-board-request
|
Paolo
:
review+
|
Details |
It's been depreciated for some time (just not marked in the idl as such). We should be using LoadURI instead.
Updated•15 years ago
|
Assignee: nobody → xfsunoles
Comment 1•15 years ago
|
||
I only rename loadUrl to loadURI under toolkit and browser, it should be very safe.
Updated•8 years ago
|
Product: Core → Firefox
Version: Trunk → unspecified
Assignee | ||
Comment 2•7 years ago
|
||
Shamelessly stealing.
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8894145 [details]
Bug 389565 - Remove nsIExternalProtocolService::LoadUrl.
https://reviewboard.mozilla.org/r/165218/#review170706
Looks simple enough, but please ensure you've tested at least one of these code paths manually.
Since some of them are fallback paths, you can test for example by forcing an exception in the main code path.
Attachment #8894145 -
Flags: review?(paolo.mozmail) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8894145 [details]
Bug 389565 - Remove nsIExternalProtocolService::LoadUrl.
https://reviewboard.mozilla.org/r/165218/#review170706
I sent a WM_APPCOMMAND | APPCOMMAND_SEND_MAIL Windows message. It will generate am "AppCommand" event, then call HandleAppCommandEvent() event listener with "SendMail" command, then call MailIntegration.sendLinkForBrowser, then call MailIntegration.sendMessage, then generate a mailto: URL and call MailIntegration._launchExternalUrl() with the mailto: URL, then call nsIExternalProtocolService.loadURI() with the URL. It worked with or without this patch.
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9b08f3cac11a
Remove nsIExternalProtocolService::LoadUrl. r=Paolo
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•