Closed
Bug 397095
Opened 17 years ago
Closed 17 years ago
prefwindow.showPane dies if no prefpanes are found
Categories
(Toolkit :: Preferences, defect)
Toolkit
Preferences
Tracking
()
RESOLVED
FIXED
People
(Reporter: mnyromyr, Assigned: mnyromyr)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
Opening a <prefwindow> without any <prefpane> elements (yet) results in:
JavaScript error: chrome://global/content/bindings/preferences.xml, line 631: aPaneElement has no properties
Attachment #281860 -
Flags: review?(gavin.sharp)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 281860 [details] [diff] [review]
easy fix
>Index: toolkit/content/widgets/preferences.xml
> <method name="showPane">
>+ if (!aPaneElement)
>+ return;
> this._selector.selectedItem = document.getAnonymousElementByAttribute(this, "pane", aPaneElement.id);
Add a newline after the return?
Attachment #281860 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → mnyromyr
|
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 281860 [details] [diff] [review]
easy fix
Very low risk null check.
Attachment #281860 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #281860 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Landed on trunk incl. requested newline.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Blocks: prefpane_migration
You need to log in
before you can comment on or make changes to this bug.
Description
•