Closed
Bug 397527
Opened 17 years ago
Closed 17 years ago
append folder and all ancestors to the include / exclude folder array in nsNavHistory::FilterResultSet(), to save repeated queries
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: moco, Assigned: moco)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
patch
|
dietrich
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
append folder and all ancestors to the include / exclude folder array in nsNavHistory::FilterResultSet(), to save repeated queries
patch in hand, currently part of bug #387996
There is no reason though that it can't land ahead of that patch.
|
Assignee | |
Comment 1•17 years ago
|
||
splitting this out from bug #387996
Attachment #282332 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 M9
|
||
Comment 2•17 years ago
|
||
Comment on attachment 282332 [details] [diff] [review]
patch
looks good, thanks seth. r=me.
Attachment #282332 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #282332 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #282332 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
fixed.
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHis
tory.cpp
new revision: 1.172; previous revision: 1.171
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
|
||
Comment 4•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•