Closed Bug 399253 Opened 17 years ago Closed 17 years ago

problems when opening the new "bookmark" dialog if closed when tags are expanded

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta1

People

(Reporter: moco, Assigned: moco)

Details

Attachments

(1 file)

error when toggling a tag checkbox from the console: ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "this._toggleTagsSelector is not a function" {file: "chrome://browser/content/places/editBookmarkOverlay.js" line: 409}]' whe n calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x80570021 (NS _ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://glob al/content/bindings/popup.xml :: hidePopup :: line 110" data: yes] ************************************************************ found this while working on bug #387996. I'll put a one liner here, and seek review.
Flags: blocking-firefox3?
Attached patch patch (deleted) — Splinter Review
Attachment #284245 - Flags: review?(dietrich)
Attachment #284245 - Flags: review?(dietrich) → review+
updating summary and elaborating on the problem. if you tag a page and leave the tag tree expanded, we'll show you the wrong thing (in the tag tree) the next time you open the bookmark dialog. fixed.
Status: NEW → ASSIGNED
Summary: error when toggling a tag checkbox → problems when opening the new "bookmark" dialog if closed when tags are expanded
fixed. Checking in browser/components/places/content/editBookmarkOverlay.js; /cvsroot/mozilla/browser/components/places/content/editBookmarkOverlay.js,v <-- editBookmarkOverlay.js new revision: 1.8; previous revision: 1.7 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3? → blocking-firefox3+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: