Using may24 m16 commercial build Mail filters ui spec: http://gooey/client/5.0/specs/mail/filters/Filters.html The current revision (4/19/00) of the message filters ui spec indicates the criteria option Age in Days to be a P4 item. It is indicated as such in the criteria table, but not in the priorities list at the end of the spec. If we are indeed considering this criteria option P4 (wouldn't make it in this release), please remove it from the filter rules criteria dropdown.

it might end up being harder to remove it than to actually implement it (i.e. it might be working right now)

Alec do whatever is easier. If you are leaving as is please move this to the future milestone.

This also applies to Search Messages ui.

nsbeta3 nomination. If you can move this bug off, please do so.

reassigning my filter bugs to gayatrib..

nominate 6.5 I vote for taking out criteria options which are not implemented.

marking nsbeta1-

reassigning to naving

Taking. Laurel, can you try again and verify that it is not implemented? If it's not. I will remove it.

triaging

bumping milestone.

I don't have the guts to completely remove this half-implemented feature, and I can't complete the implementation so I guess the only choice left is to disable it. I've got a fix for this, which is simply to comment out as little code as possible - to make it easy for Naving or whoever the person who'll finish the implementation will be. Patch coming up.

If possible, I would like Naving to r= and sspitzer/bienvenu to sr=. It's a three-liner and will fix another bug I have about the OK button not working when trying to save a filter with an AgeInDays criterium.

I think we should just implement it, if not already implemented in the backend. We didn't want it in 6.1, but I don't see why Mozilla 1.0 shouldn't have it.

Well, it looks like it's implemented backend so I /assume/ it's a few bugs here and there to fix. Can't we take it out for now and file a bug on naving to complete it?

The problem might be in the front end - I think we should investigate it instead of just disabling the UI.

That would be nice, unfortunately I'm unexperienced with search stuff. I propose that either someone more experienced with search stuff fix this, not later (because then we'll have the disfunctional item hanging around for a good while), or we checkin my patch and file a new bug to investigate the breakage.

I tried an age in days is less than 5 days search on both imap and local folders and it worked fine. I think it would be a mistake to remove this.

Oh, I never proposed to remove it! I tried "Age in days is 3 days" on my POP account and it didn't find anything.

I thought you were removing the age in days criteria from the search ui. "is less than" worked for me - I can see how "is" wouldn't work because we do age by converting the age of the message from days to microseconds, and we might not have the logic to make the match within 24 hours. And I suspect, though I can't verify, that 4.x didn't support "is" but only less than or greater than, in which case the fix would be to fix the UI not to contain "is". Perhaps someone with 4.x could check it out.

Wow, "Age in days less than" works here too!

I'm making a patch to * Fix the wording to be consistent with other criterion wordings (Age in days instead of Age In Days) * Remove the "is" choice for Age in days

Guess I request r/sr for the new patch

no go on this patch. don't remove "is", 4.x supported age in day & "is". let's just fix the code to make it work.

Reassign to seth who is working on this...

fix in hand, I'll attach the patch.

whoops, that patch is bad. I need to use the cutOff date, not now. thanks to bienvenu for pointing it out. new patch on the way.

looks good, r/sr=bienvenu

r=hwaara

note, this fixes search and filters. I was able to add an "age in days" filter and use it. I'll land when the tree opens.

fixed.

OK with Search messages, POP and IMAP using aug10 commercial trunk build:mac OS 9.0, win98, linux rh6.2. Still need to test with filters...

OK with filters using aug10 commercial trunk build. POP only (not available in IMAP choices). Tested very basic Age in Days IS filter. Any specific problems found with age in days will be logged separately.