Closed Bug 407086 Opened 17 years ago Closed 17 years ago

remove some unused unconstrained width handling code

Categories

(Core :: Layout: Block and Inline, defect)

Product:
Core
Component:
Layout: Block and Inline
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(3 files, 1 obsolete file)

remove nsHTMLReflowState::mRightEdge
(deleted), patch
roc
: review+
roc
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
remove code to handle nsLineLayout::mRightEdge being NS_UNCONSTRAINEDSIZE
(deleted), patch
roc
: review+
roc
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
remove the height output from nsLineLayout::EndSpan
(deleted), patch
roc
: review+
roc
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
While I was reviewing bug 405577, I found a bunch of unused code that should have been removed during the reflow branch landing -- mostly dealing with unconstrained width handling, but also a little bit left over from maxelementsize calculation (that could have been removed when I changed maxelementsize to maxelementwidth). Patches to follow, with explanations.
Remove an unused member variable from nsHTMLReflowState. Should have been removed even before bug 192767, which removed the last nontrivial setter.
Attachment #291799 - Flags: superreview?(roc)
Attachment #291799 - Flags: review?(roc)
This should have been done on the reflow branch. It makes nsFirstLetterFrame pass through a real available width to BeginLineReflow; other than that it removes unconstrained width handling code.
Attachment #291800 - Flags: superreview?(roc)
Attachment #291800 - Flags: review?(roc)
I noticed this while writing the previous patch, which this applies on top of. This should have been done along with bug 186953.
Attachment #291801 - Flags: superreview?(roc)
Attachment #291801 - Flags: review?(roc)
Attachment #291799 - Flags: superreview?(roc)
Attachment #291799 - Flags: superreview+
Attachment #291799 - Flags: review?(roc)
Attachment #291799 - Flags: review+
Comment on attachment 291800 [details] [diff] [review] remove code to handle nsLineLayout::mRightEdge being NS_UNCONSTRAINEDSIZE + availableWidth = PR_MAX(0, availableWidth); This conflicts with the patch we just landed, but no worries...
Attachment #291800 - Flags: superreview?(roc)
Attachment #291800 - Flags: superreview+
Attachment #291800 - Flags: review?(roc)
Attachment #291800 - Flags: review+
Comment on attachment 291801 [details] [diff] [review] remove the height output from nsLineLayout::EndSpan Might as well make EndSpan return the width directly if you're doing this
Good idea.
Attachment #291801 - Attachment is obsolete: true
Attachment #291845 - Flags: superreview?(roc)
Attachment #291845 - Flags: review?(roc)
Attachment #291801 - Flags: superreview?(roc)
Attachment #291801 - Flags: review?(roc)
Attachment #291845 - Flags: superreview?(roc)
Attachment #291845 - Flags: superreview+
Attachment #291845 - Flags: review?(roc)
Attachment #291845 - Flags: review+
Attachment #291799 - Flags: approval1.9?
Attachment #291800 - Flags: approval1.9?
Attachment #291845 - Flags: approval1.9?
Attachment #291800 - Flags: approval1.9? → approval1.9+
Attachment #291799 - Flags: approval1.9? → approval1.9+
Attachment #291845 - Flags: approval1.9? → approval1.9+
All three patches checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Depends on: 408304
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: