Closed Bug 40855 Opened 25 years ago Closed 24 years ago

comment interpreted as <br> when inside <table><center>

Categories

(Core :: DOM: HTML Parser, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: xalkina, Assigned: harishd)

References

()

Details

(Keywords: compat, relnote, testcase, Whiteboard: nsbeta3 relnote-devel)

Attachments

(5 files)

at bottom of page, there's a "page was updated <date>" entry. in the source there's a comment between the text and the date. mozilla renders as if there was a <br>. linux-2000052520
Attached file testcase (deleted) —
Christos' testcase is simply the full page...thats what the URL field is for Christos. Problem appears to be with text inside a <center> block thats inside a <table>, which doesn't seem like it would be valid HTML. Sun's pages are absolutly DISGUSTING, it's filled with this kind of cruft. Attaching minimal test case.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase
Summary: comment interpreted as <br>?? → comment interpreted as <br> when inside <table><center>
Attached file more minimal (deleted) —
Arg, collitions... gotta start using makingtest. My testcase is more minimal, anyhow.
Yes, I got a collision, too. Will start using `makingtest', too. The only thing left from my collision-comment is that 4.x displays all testcases as expected on one line.
Attached file testcase with colors (deleted) —
The above testcase makes this look much more like a Parser problem (although I don't have access to viewer now, so I can't tell for sure). Changing to Parser.
Assignee: clayton → rickg
Component: Layout → Parser
QA Contact: petersen → janc
Over to my list for triage.
Assignee: rickg → harishd
The layout does look bad...but..the bug as such is not a high priority. In other words it's not a beta blocker. Moving to M18.
Status: NEW → ASSIGNED
Target Milestone: --- → M18
Works fine in linux/2000052920 in all pages at javasoft I checked
see it again as of 2000060908 on linux, there are some pages @ Sun however that now do it with <p align="center"> instead of <center> and there it works fine.
Egads. This is due to SaveTokens(). The <center>, text, and comment are inside a <table> (malformed). They're supposed to get pushed out, but for some reason the <center> is closed when the comment appears. Ick, ick, ick. Bad Harish.
That's because comments, any where insided a table, are treated as legal. And why shouldn't it be?????? Anyway, the fix would be trivial. I think you would see the same effect if there was a CAPTION inside CENTER instead of the comment.
Recommended for nsbeta3. Comments should not be the culprit in handling illegal table contents.
Keywords: compat, nsbeta3
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: M18 → Future
Marking nsbeta3-
Whiteboard: [nsbeta3-]
I think we should reconsider this. When bogus content is found in a <table> before <tr>, it gets pushed out like nav did it. For some reason, text and comments aren't getting moved. This could lead to pretty bad (and non-compatible) behavior.
Whiteboard: [nsbeta3-] → nsbeta3
*** Bug 52012 has been marked as a duplicate of this bug. ***
All/all. I can reproduce this on Windows 98, 2000093008. Should this get a release note?
Keywords: relnote
OS: Linux → All
Hardware: PC → All
Whiteboard: nsbeta3 → nsbeta3 relnote-devel
Target Milestone: Future → mozilla0.8
Nom. nsbeta1. We should handle HTML comments correctly. ;->
Keywords: nsbeta1
The bug seems to have gone away! Jan, could you please verify this. Thanx. Marking WFM.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
Still broken on MTEST builds: 2001-01-31-14-MTEST : Win2K 2001-01-30-21-MTEST : Mac but working fine on trunk builds: 2001-02-02-10-Mtrunk : Win98 2001-02-02-10-Mtrunk : Linux 2001-02-02-09-Mtrunk : Mac
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
What's an MTEST build?
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.8 → mozilla0.9
wfm2, on both linux/2001020306 & win/2001020308
Fix is in. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
updated qa contact.
QA Contact: janc → bsharma
Verified on build: 2001-06-20-04-Trunk platform: Win NT The above test case and the test case with id 9299 loads fine.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: