Closed
Bug 409326
Opened 17 years ago
Closed 17 years ago
Complement eTLD+1 status with a full host tooltip
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.9beta3
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Mardak
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
From bug 397655 comment 39:
* tooltips for status
- show whatever is shown for in progress downloads
- for done (anything showing eTLD+1), tooltip is just the whole hostname
|
Assignee | |
Comment 1•17 years ago
|
||
You know.. I might as well just convert the crop=right to crop=end and make all those lines consistent...
|
||
Comment 2•17 years ago
|
||
Comment on attachment 294147 [details] [diff] [review]
v1
s/getDisplayHost/getHost/
r=sdwilsh
Attachment #294147 -
Flags: review?(comrade693+bmo) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
(In reply to comment #2)
> s/getDisplayHost/getHost/
Rename the function everywhere including sql?
|
|
Assignee | |
Comment 4•17 years ago
|
||
Renamed the js function to getHost but kept the sql version as getDisplayHost.
Attachment #294147 -
Attachment is obsolete: true
Attachment #294554 -
Flags: review+
Attachment #294554 -
Flags: approval1.9?
|
|
||
Comment 5•17 years ago
|
||
(In reply to comment #4)
> Renamed the js function to getHost but kept the sql version as getDisplayHost.
That's exactly what I wanted.
|
||
Comment 6•17 years ago
|
||
Comment on attachment 294554 [details] [diff] [review]
v1.1
a=beltzner for 1.9
Attachment #294554 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 7•17 years ago
|
||
Checking in toolkit/mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v <-- download.xml
new revision: 1.50; previous revision: 1.49
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v <-- downloads.js
new revision: 1.126; previous revision: 1.125
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
|
||
Comment 8•17 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=5016
in-litmus+
Verified FIXED using:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•