Closed
Bug 4106
Opened 26 years ago
Closed 26 years ago
javascript mods to query.cgi do not work on MS IE
Categories
(Bugzilla :: Bugzilla-General, defect, P3)
Tracking
()
VERIFIED
FIXED
Bugzilla old
People
(Reporter: daa, Assigned: terry)
Details
the javascript added to query.cgi do not work on any version of MSIE, because
MSIE jscript does not support the .push method of an array object
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 1•26 years ago
|
||
I was incorrectly marking the JavaScript as being version 1.1. Now that
I've changed it to 1.2, you will hopefully no longer have this problem. If
you do, please REOPEN this bug.
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Reporter | ||
Comment 2•26 years ago
|
||
MS does not support the .push method on any version of IE jscript
Reporter | ||
Updated•26 years ago
|
Resolution: FIXED → ---
Reporter | ||
Comment 3•26 years ago
|
||
diff -c /home/daa/bugs/query.cgi bugzilla/query.cgi
*** /home/daa/bugs/query.cgi Sat Mar 27 04:15:17 1999
--- bugzilla/query.cgi Sat Mar 27 04:16:51 1999
***************
*** 215,226 ****
}
- $jscript .= q{
- // Apparently, IE4 chokes on the below, so do nothing if running that.
- var agt=navigator.userAgent.toLowerCase();
- if (!(agt.indexOf("msie") != -1))
- };
- $jscript .= "{";
for $p (@::legal_product) {
foreach $c (@{$::components{$p}}) {
$jscript .= "cpts['$c'].push('$p');\n";
--- 215,220 ----
***************
*** 229,236 ****
$jscript .= "vers['$v'].push('$p');\n";
}
}
- $jscript .= "};";
-
$i = 0;
$jscript .= q{
Reporter | ||
Updated•26 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → NEW
Assignee | ||
Comment 4•26 years ago
|
||
The only person who should ever mark a bug as "Assigned" is the person who
actually owns the bug.
even after the updates from bug #4133 and v1.30 of query.cgi, the javascript
still bombs on ie. this patch here (or some varient of it) still needs to be
implemented.
my suggestion would be to add these four lines:
diff -r1.31 query.cgi
199a200,202
> // Apparently, IE4 chokes on the below, so do nothing if running that.
> var agt=navigator.userAgent.toLowerCase();
> if ((agt.indexOf("msie") == -1)) {
229a233
> \} // end IE4 choke around
but, your mileage will vary.
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•26 years ago
|
||
OK, I have applied the above patch.
Comment 7•24 years ago
|
||
per Terry, auto-verifying any resolved bug that hasn't been touched since before
2.10 was released.
Status: RESOLVED → VERIFIED
Comment 8•23 years ago
|
||
Moving to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
QA Contact: matty
Target Milestone: --- → Bugzilla old
Version: other → unspecified
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•