Closed
Bug 411620
Opened 17 years ago
Closed 17 years ago
Migrate SeaMonkey's tabbed browsing preferences to new pref window
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(3 files)
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
image/png
|
Details |
Broken tab prefs pane in Modern
I re-indented the file so -w version coming up... Not much to say, everything appears to work on Mac here - only thing was "inverted" instead of "reversed" :-)
Attachment #296288 -
Flags: review?(neil)
|
Assignee | |
Comment 1•17 years ago
|
||
|
|
Assignee | |
Comment 2•17 years ago
|
||
So, I never checked Modern and it appears that the prefs pane is cut-off at the bottom...
Attachment #296288 -
Attachment is obsolete: true
Attachment #296290 -
Attachment is obsolete: true
Attachment #296288 -
Flags: review?(neil)
|
|
Assignee | |
Comment 3•17 years ago
|
||
Hmm, so this is a general issue.
|
|
Assignee | |
Comment 4•17 years ago
|
||
I've just had a conversation with Ratty. Bug 390270 is to blame here - I don't think there shouldn't be any padding on prefpane and .prefWindow-dlgbuttons. Only the child elements should have padding. Also, the prefwindow looks like it should have a different padding in communicator/preferences.css. I'll file a new bug on this tomorrow.
|
|
Assignee | |
Updated•17 years ago
|
Attachment #296288 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•17 years ago
|
Attachment #296290 -
Attachment is obsolete: false
|
|
Assignee | |
Comment 5•17 years ago
|
||
Comment on attachment 296288 [details] [diff] [review]
Migrate the prefs
Filed bug 412167 regarding the padding issues.
Attachment #296288 -
Flags: review?(neil)
|
||
Updated•17 years ago
|
Attachment #296288 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Checking in suite/common/pref/pref-tabs.xul;
/cvsroot/mozilla/suite/common/pref/pref-tabs.xul,v <-- pref-tabs.xul
new revision: 1.14; previous revision: 1.13
done
Checking in suite/common/pref/preferences.xul;
/cvsroot/mozilla/suite/common/pref/preferences.xul,v <-- preferences.xul
new revision: 1.8; previous revision: 1.7
done
(this one had to go in a separate check-in)
Checking in suite/common/pref/preftree.xul;
/cvsroot/mozilla/suite/common/pref/preftree.xul,v <-- preftree.xul
new revision: 1.112; previous revision: 1.111
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•