Closed Bug 4131 Opened 26 years ago Closed 26 years ago

Missing NS_ADDREF() in nsImageManager.cpp

Categories

(Core Graveyard :: GFX, defect, P3)

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jst, Assigned: michaelp)

Details

(Don't know if Layout is the correct component for this, if not I'm sorry). NS_NewImageManager() is missing an NS_ADDREF(), this is not triggered in viewer or apprunner but it is triggerd by one of the examples from http://www.doczilla.com/development/samples.zip (Embedding NGLayout Programmatically). The problem is that NS_NewImageManager() stores a pointer to the imagemanager in a global static pointer (gImageManager) and returns a pointer to the caller with a refcount of 1, thus the imagemenager is deleted when the caller releases it (if there's only one) but the static global ponter still points to the deleted imagemanager. From reading the comments the imagemanager will become a service but for the moment this is a bug!
Assignee: troy → michaelp
Component: Layout → Compositor
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
fixed last week or so.
Status: RESOLVED → VERIFIED
Fixed in April 13th Build
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.