Closed
Bug 41445
Opened 25 years ago
Closed 23 years ago
[RFE] Sidebar context menu items in sidebar tab header
Categories
(SeaMonkey :: Sidebar, enhancement, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: bugzilla, Assigned: samir_bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
A context menu should be implemented for the sidebar.
Fx rightclick pressing in the title should give the user the option to "remove
the sidebar", "add to the sidebar", and "customize the sidebar".
Rightclick pressing on one of the tabs should give the option to "reload the tab
", "customize the tab" and to "remove the tab".
Comment 1•24 years ago
|
||
marking rfe, m19
Summary: Context menu for sidebar → [RFE] Context menus for sidebar: title, tabs
Target Milestone: --- → M19
Comment 2•24 years ago
|
||
Reassigning 50 Sidebar bugs to Matt. I was told this was going to be done
shortly about two months ago, but it clearly hasn't been. I think that's long
enough for all these bugs to remain assigned to nobody.
Feel free to filter all this spam into the trashcan by looking for this string
in the message body: ducksgoquack
Assignee: slamm → matt
Reproducing my comments from bug 86557:
All the tabs now have a convenient context menu, except the "My Sidebar" tab
itself. It would be nice if right-cliking on that tab could popup
the same menu that the "Tabs" has. So this bug is a RFE to allow the readily
available "Tabs" menu appear as a context menu (i.e., next to the mouse) when
right-clicking on the "My Sidebar" tab itself.
Reporter | ||
Comment 6•23 years ago
|
||
RFE cleanup. RFE is already indicated by the Severity field...Sorry for the
spam!
Severity: normal → enhancement
Summary: [RFE] Context menus for sidebar: title, tabs → Context menus for sidebar: title, tabs
Assignee | ||
Updated•23 years ago
|
Assignee: matt → sgehani
Blocks: 102472
Priority: P3 → P2
Summary: Context menus for sidebar: title, tabs → [RFE] context menu items: remove and reload panel in sidebar panel header
Target Milestone: --- → mozilla0.9.6
Assignee | ||
Comment 7•23 years ago
|
||
This is an RFE for remove and reload panels. Customize, switch to, and hide
panel are already in. Please file a separate bug for any sidebar main header
(My Sidebar/Sidebar item rbs alluded to above) context menu RFEs.
My bug was bug 86557 and it was marked as duplicate of this one. Feel free t
re-open it.
Assignee | ||
Comment 9•23 years ago
|
||
The current poropsed changes are reflected at:
<http://www.mozilla.org/xpapps/sidebar/proposals/ctx-menus.html>
The newsgroup discussion for this topic is at:
<news://news.mozilla.org:119/3BD07372.2050401@domain.invalid>
Comment 10•23 years ago
|
||
See also bug 84514, add "tab properties..." to this context menu.
Assignee | ||
Updated•23 years ago
|
Summary: [RFE] context menu items: remove and reload panel in sidebar panel header → [RFE] sidebar context menu items: remove and reload panel in sidebar panel header
Comment 11•23 years ago
|
||
A 'Remove tab' item is important. Right now you can hide a tab by using the
'Tabs' flyout menu. However, someone decided this was too much effort for the
user and that this should be possible by using the tab title's context menu.
Removing a tab, on the other hand, requires a trip to the 'Customize Sidebar'
dialogue, which is far more effort than needed to hide a tab, but there's no
context menu item for it.
Assignee | ||
Comment 12•23 years ago
|
||
Moving to mozilla0.9.7.
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Assignee | ||
Comment 13•23 years ago
|
||
*** Bug 67719 has been marked as a duplicate of this bug. ***
Comment 15•23 years ago
|
||
what are the chances this will make the 098 milestone?
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Assignee | ||
Comment 17•23 years ago
|
||
Sidebar tab header context menus are addressed in the new context menu spec:
<http://www.mozilla.org/projects/ui/communicator/framework/contextmenus/cmrev2.html#Anchor-28250>
Summary: [RFE] sidebar context menu items: remove and reload panel in sidebar panel header → [RFE] Sidebar context menu items in sidebar tab header
Assignee | ||
Comment 18•23 years ago
|
||
Assignee | ||
Comment 19•23 years ago
|
||
morse, please r.
alecf, please sr.
Assignee | ||
Comment 20•23 years ago
|
||
Comment 21•23 years ago
|
||
Comment on attachment 68242 [details] [diff] [review]
Same patch as above but ``diff -w'' for reviewers' benefit.
r=morse
Attachment #68242 -
Flags: review+
Comment 22•23 years ago
|
||
Comment on attachment 68242 [details] [diff] [review]
Same patch as above but ``diff -w'' for reviewers' benefit.
comments comments and more comments!
code looks fine but you really need to document way more.
Attachment #68242 -
Flags: needs-work+
Assignee | ||
Comment 23•23 years ago
|
||
alecf, please sr. Thanks.
Assignee | ||
Updated•23 years ago
|
Attachment #68240 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Attachment #68242 -
Attachment is obsolete: true
Comment 24•23 years ago
|
||
Comment on attachment 68362 [details] [diff] [review]
Patch rev 2 with code commented now.
I hate to keep belabor this but comments should explain WHY you're doing what
you're doing .. i.e.
// the current panel can be reloaded, but other panels are
// not showing any content, so we only allow you to switch to other panels..
>+ if (panel.is_selected())
>+ {
>+ // for the currently selected panel hide the ``Switch to Tab'' item
>+ // and enable the ``Reload'' item
>+ switchItem.setAttribute("collapsed", "true");
>+ reloadItem.removeAttribute("disabled");
>+ }
>+ else
>+ {
>+ // for panels that aren't the currently selected one show the
>+ // ``Switch to Tab'' item and disable the ``Reload'' item
>+ switchItem.removeAttribute("collapsed");
>+ reloadItem.setAttribute("disabled", "true");
>+ }
>+
Anyway, with that sort of comment, sr=alecf
Attachment #68362 -
Flags: superreview+
Assignee | ||
Comment 25•23 years ago
|
||
OK, suggestion incorporated. Thanks for the reviews.
Keywords: review
Whiteboard: [ready to checkin]
Assignee | ||
Comment 26•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [ready to checkin]
Comment 27•23 years ago
|
||
okay now I see the following in the context menu for tab header:
Switch to Tab
Reload
Stop
Hide Tab
Customize My Sidebar
If this is not correct, then REOPEN.
verified in 2/20 build.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•