Closed
Bug 418079
Opened 17 years ago
Closed 17 years ago
[Esc] doesn't cancel changes in contextual bookmark dialog
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: zeniko, Assigned: asaf)
References
()
Details
Steps to Reproduce:
1. Bookmark this page: Ctrl+D, Enter
2. Change the bookmark's title: Ctrl+D and enter "asfd" (or whatever)
3. Before hitting Enter, reconsider and hit Escape
Expected result:
No change is made.
Actual result:
Hitting Ctrl+D again will reveal that the bookmark's title has been changed as if I had hit Enter at step 3 (i.e. Escape maps to Done instead of Cancel).
Now the only way to undo this change is through the Library (where I have to trust Undo to do the right thing because it doesn't indicate what it will actually undo).
So to keep things consistent, either Escape should map to the Cancel button or there should be no Cancel button at all. As a Windows user, I'd vote for the former.
Whether there is a Cancel button or not, pressing Esc is expected to cancel changes.
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
Reporter | ||
Updated•17 years ago
|
Reporter | ||
Comment 2•17 years ago
|
||
Doesn't look like the Cancel button is going away... requesting blocking.
Flags: blocking-firefox3?
Comment 3•17 years ago
|
||
Yes, agree that ESC should = backout/undo/cancel
Couple more notes:
- you can reproduce the STR with Ctrl+D *or* by clicking on the star
- changes to the folder field *are* cancelled by ESC, changes to name or tags are not
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Reporter | ||
Comment 4•17 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005
This seems to have been fixed in bug 394252. -> WORKSFORME
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•17 years ago
|
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → mano
Status: REOPENED → NEW
Target Milestone: --- → Firefox 3 beta5
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Comment 5•17 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031804 Minefield/3.0b5pre ID:2008031804
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Flags: in-litmus?
Comment 6•16 years ago
|
||
Created litmus test case https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=7460 for regression testing.
Updated•16 years ago
|
Flags: in-litmus? → in-litmus+
Comment 7•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•