When I try to delete bookmarks from the sidebar using the context menu, I get an modal dialog asking me if I'm sure. This is annoying babying. I know exactly what I'm doing ;) The bookmark should just disappear. This behaviour is inconsistent with 4.x which just deleted the bookmark.

oops, this is cmd is implemented FE code. reassigning to myself as slamm is on vacation. sorry for the spam, robert.

ben, stealing if you don't mind, I have a fix for this. do you want this to be the same behavior for manage bookmarks as well? I'm pretty sure my patch is going to affect that also (but I can't test right now since manage bookmarks is broken), but if you want that window to continue to have the confirmation, I'll just change it. so we want no confirm for anything, even deleting multiple items? btw, why doesn't the delete key work in the sidebar panel?

I believe the fine grained difference here is the delete _key_ should come with a warning. I don't type too well and I'd be pretty pissed if a tap of the delete key took out one of my precious bookmarks. Can we implement it such that the delete key gets a warning but not the other more deliberate gestures?

That can be done, I guess. Prob. will require a bit more work since right now I think the delete key just observes the context menu command (and thus would share the same code). I'll check it out

notice bug 48073. I stand by my original claim: If I select delete from a menu anywhere -ZAP! it should be gone(hope undo works). If I press the button, I'd like a confirmation, cuz I might not even notice otherwise.

Nah. Menu items, and their associated keyboard shortcuts, should always do exactly the same thing. Otherwise you're misleading the user. The trouble is that at the moment, bookmarks are halfway in severity between text (for which deletion is immediate) and files (for which deletion requires confirmation). I'd hope that in the future they're going to become more like files (so your bookmarks file can be synchronized with a folder full of Internet shortcuts, for example; or when you delete a bookmark, it ends up in the Trash/ Recycle Bin). Your fear that you might hit Del/Backspace by mistake is reasonable, though. I think the problem is that the keyboard shortcut is too easy. Perhaps it could be changed to Ctrl+Del/+Backspace, which is the shortcut for trashing files on Mac? (But then Windows allows deletion of files with plain Backspace/Delete and a confirmation dialog ...)

*** Bug 48073 has been marked as a duplicate of this bug. ***

need a UI/UE decision here (I don't recommend changing the delete key to modifier+delete)

This bug popped onto my radar again and I see that I never responded to mpt's comments. "Nah. Menu items, and their associated keyboard shortcuts, should always do exactly the same thing. Otherwise you're misleading the user." Of course they _do_ the same thing, one just comes with a warning because it's way easier to just tap a key whereas it's pretty damn hard to open a menu and select an item by dropping something on your keyboard or whatever. Tap the reset button on your mac vs. selecting Special|Shut Down and tell me I'm wrong. "(But then Windows allows deletion of files with plain Backspace/Delete and a confirmation dialog ...)" that's probably because that's the exact right thing to do :-). You've answered the question. This seems even more important now that Undo isn't going to work any time soon.

damn. somebody went and implemented this anyway. I'll be bitching in bug 54813 that I want the warning back for hitting the button but not for selecting the menuitem.

> Tap the reset button on your mac vs. selecting Special|Shut Down and tell me > I'm wrong. Ok, you're wrong. :-) The Shut Down menu item and the Power key do two completely different things. The former shuts the computer down, whereas the latter opens a dialog asking you whether you want to shut down, restart, or sleep. That's why the Power key is not shown as a shortcut for Shut Down in the Special menu -- which means it cannot be used as a precedent for this bug anyway.

Works for me: Platform: PC OS: Windows 98 Mozilla Build: 2000101214 M18 Trunk Build Marking as Verified.