Closed
Bug 420589
Opened 17 years ago
Closed 16 years ago
Add about dialog
Categories
(Other Applications :: ChatZilla, enhancement)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)
References
Details
(Whiteboard: [cz-0.9.84])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
image/x-png
|
Details | |
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Picture of dialog from patch
We need one, really, so we can credit people properly. It can be based on the one Firefox's Extension Manager uses, but we should replace that as well when done.
|
Assignee | |
Updated•17 years ago
|
Assignee: rginda → silver
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #330465 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 2•16 years ago
|
||
|
||
Comment 3•16 years ago
|
||
This all looks good to me, but I would like to actually look at it on Windows XP, Ubuntu and Mac OS X, to make sure the dialog is the right size in other OS's as well (given how much issues there already are/were with the pref window...).
If I haven't stamped this within the next 2 days or so, please poke me (here, email, jabber, IRC, as you wish).
|
|
||
Updated•16 years ago
|
Attachment #330465 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 330465 [details] [diff] [review]
Add about dialog with much styling and common version code
>Index: xul/content/commands.js
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/irc/xul/content/commands.js,v
>retrieving revision 1.159
>diff -d -p -u -6 -r1.159 commands.js
>--- xul/content/commands.js 20 Jun 2008 15:09:55 -0000 1.159
>+++ xul/content/commands.js 20 Jul 2008 15:23:12 -0000
>@@ -2777,14 +2777,17 @@ function cmdTopic(e)
> else
> e.channel.setTopic(e.newTopic);
> }
>
> function cmdAbout(e)
> {
>- display(CIRCServer.prototype.VERSION_RPLY);
>- display(MSG_HOMEPAGE);
>+ if ("aboutDialog" in client)
>+ return client.aboutDialog.focus();
>+
>+ window.openDialog("chrome://chatzilla/content/about/about.xul", "",
>+ "chrome,dialog", { client: client });
Even a dialog when we do /about ? :-(
Maybe we can just output the same data to the output window? Would be nicer, I think... If you agree, please file a followup bug! :-)
>Index: xul\skin\about.css
>===================================================================
>+.contributors {
>+}
>+
Nit: remove empty block.
r=me with the nit fixed and followup bug filed / disagreed with. :-)
|
|
Assignee | |
Comment 5•16 years ago
|
||
This patch makes /about (when done in the input box) show the same text as before, but with an additional button to open the dialog. Had to fix a bug with the inline button dispatch code to make it work, though: when dispatching x-cz-command, we were losing the source value.
Attachment #330465 -
Attachment is obsolete: true
Attachment #338463 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 338463 [details] [diff] [review]
Updated patch that keeps /about working as before
Looks good, but it still has the empty block I mentioned in comment #4. Does it have some function that I missed? If not, please get rid of it.
r=me with that.
Attachment #338463 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 7•16 years ago
|
||
Checked in (without empty CSS block) --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.84]
You need to log in
before you can comment on or make changes to this bug.
Description
•