Open Bug 424378 Opened 16 years ago Updated 3 years ago

User is able to press cmd+q or firefox->quit multiple times while the Close Multiple Tabs quitting dialogue box is open [Mac]

Categories

(Core :: Widget: Cocoa, defect, P3)

x86
macOS
defect

Tracking

()

People

(Reporter: Agnapot, Unassigned)

References

Details

(Keywords: regression)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4

User is able to press command+q or firefox->quit while the Close Multiple Tabs quitting dialogue box is open

Reproducible: Always

Steps to Reproduce:
1. Open firefox and open 2 or more tabs
2. Press cmd+q or firefox->quit
3. Press cmd+q or firefox->quit again
Actual Results:  
The quit dialogue box opens again, and when quit is pressed, it does not quit

Expected Results:  
User should be barred from pressing cmd+q or firefox->quit when the quit dialogue box is open

Each time the user presses cmd+q another dialogue pops up, however when the user presses quit on the top-most box, two dialogue boxes are quit, making me think it's a toggle somewhere.
I've seen this too.

It's very annoying.
Assignee: nobody → joshmoz
Component: General → Widget: Cocoa
Product: Firefox → Core
QA Contact: general → cocoa
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
This doesn't happen with Firefox 2.0.0.12, so it's a regression.
Flags: blocking1.9?
Keywords: regression
It doesn't happen on Linux with Ctrl-q.  (The problem doesn't arise on Windows, where Minefield doesn't have a keyboard shortcut for File : Exit.)
Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-
Priority: -- → P2
Assignee: joshmoz → smichaud
I'm seeing this on on the latest nightlies for trunk and Shiretoko for OS X, testing against Linux did not show the problem.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214



ALso, adding wanted flags for 1.9.1 and trunk since 1.9.0 is already plus'd and this issue is seen on the builds above.
Flags: wanted1.9.2?
Flags: wanted1.9.1?
Hardware: PowerPC → x86
Entirely unrelated.

The STR from comment #0 could use a bit more fleshing out:

1) Run Firefox and open two or more tabs.

2) Press command-q or choose Firefox : Quit.

   A dialog appears asking if you want to save your tabs, and gives
   you three choices -- Quit, Cancel, Save and Quit.

3) Press command-q (or choose Firefox : Quit) again.

   Nothing should happen, since you're already in a modal dialog (a
   Gecko-modal dialog).

   But instead another, identical dialog opens on top of the first
   one.  You can't see this directly (since the dialogs don't have
   titlebars and can't be moved).  But you'll find that you have to
   press Cancel (or hit the ESC key) exactly as many times as you
   originally pressed command-q, in order to make all the dialogs go
   away.

   Pressing "Quit" or "Save and Quit" will generally also work.  But
   you need to do it several times (in order to make all the extra
   dialogs go away).

I hope this is one of the problems I can solve when I get to bug
478073.
> Entirely unrelated.

That's a bit too strong.

Looking again it does seem to be related, and to be something I should try to fix in my work on bug 478073.  But it's not a dup.
Depends on: 478073
Summary: User is able to press cmd+q or firefox->quit multiple times → User is able to press cmd+q or firefox->quit multiple times while the Close Multiple Tabs quitting dialogue box is open [Mac]
I expect this bug still happens, but I almost certainly will never have time to do any more work on it.
Assignee: smichaud → nobody
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Does this still happen? There was some work in this area in bug 550559.

This still happens.

Even worse: when Cmd + Q is hold you have to confirm or cancel multiple dialogs. It appears the choice of the first dialog is taken.

As holding Cmd + Q for a short time may happen commonly for some users, maybe this would be a reason to reprioritise?

Flags: needinfo?(spohl.mozilla.bugs)
Severity: normal → S3
Flags: needinfo?(spohl.mozilla.bugs)
You need to log in before you can comment on or make changes to this bug.