Closed Bug 4330 Opened 26 years ago Closed 26 years ago

viewer.exe crash when clicking on Display Cookies menu item

Categories

(Core Graveyard :: Viewer App, defect, P1)

x86
Windows 95

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rasmusa, Assigned: morse)

Details

two instances of the problem: VIEWER forårsagede en ugyldig sidefejl i modul KERNEL32.DLL på adressen 022f:bff7989a. Indhold af registrene: EAX=00000020 CS=022f EIP=bff7989a EFLGS=00010202 EBX=00000000 SS=0237 ESP=0094f8d4 EBP=0094f8e0 ECX=00550500 DS=0237 ESI=00000020 FS=28ff EDX=00000024 ES=0237 EDI=78027013 GS=0000 Byte ved CS:EIP: 83 3e 04 74 10 6a 00 6a 00 6a 00 68 05 00 00 c0 Indhold af stakken: 00000000 7800dd30 00000020 0094f950 78028ce1 00000000 78027013 00551fac 00526e71 0128000c 00000001 00b41fc0 00000000 00000000 00b41fc0 00001388 VIEWER forårsagede en ugyldig sidefejl i modul KERNEL32.DLL på adressen 022f:bff7989a. Indhold af registrene: EAX=00000020 CS=022f EIP=bff7989a EFLGS=00010202 EBX=00000000 SS=0237 ESP=0077f8d4 EBP=0077f8e0 ECX=004b0500 DS=0237 ESI=00000020 FS=4117 EDX=00000024 ES=0237 EDI=78027013 GS=0000 Byte ved CS:EIP: 83 3e 04 74 10 6a 00 6a 00 6a 00 68 05 00 00 c0 Indhold af stakken: 00000000 7800dd30 00000020 0077f950 78028ce1 00000000 78027013 004b1fac 00486e71 011a000c 00000001 009827e0 00000000 00000000 009827e0 00001388 crashed when I went to "Display Cookies" using the 3.25.99 build of NGLayout running viewer.exe on Win 95 4.00.950 B platform. I tried it two times, and it crashed both ... viewer.exe using the 3.26.99 build crashed just running?
Assignee: rickg → dp
Priority: P1
DP -- there's two problems here. First, we are legitimately crashing; see the stack trace below. Second, netlib should not be generating HTML. See me to find out how we can fix this. NTDLL! 77f6741b() fread(void * 0x01136630, unsigned int 1, unsigned int 16, _iobuf * 0x00000000) line 75 + 9 bytes XP_MakeRawHTMLDialog(void * 0x00000000, _XPDialogInfo * 0x0058a590 dialogInfo, int 15334, _XPDialogStrings * 0x011369d0, int 1, void * 0x011358e0) line 3890 + 20 bytes net_DisplayCookieInfoAsHTML(MWContext_ * 0x00000000, char * 0x00000000) line 5554 + 30 bytes NET_DisplayCookieInfoAsHTML(MWContext_ * 0x00000000) line 5586 + 11 bytes nsNetlibService::NET_DisplayCookieInfoAsHTML(nsNetlibService * const 0x0106bc50) line 717 + 7 bytes nsBrowserWindow::DispatchMenuItem(int 40293) line 660 + 12 bytes nsNativeBrowserWindow::DispatchMenuItem(int 40293) line 93 HandleBrowserEvent(nsGUIEvent * 0x0012fea4) line 331 + 18 bytes nsWindow::DispatchEvent(nsWindow * const 0x01094ed0, nsGUIEvent * 0x0012fea4, nsEventStatus & nsEventStatus_eIgnore) line 416 + 10 bytes nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012fea4) line 432 nsWindow::ProcessMessage(unsigned int 273, unsigned int 40293, long 0, long * 0x0012fef4) line 1700 + 21 bytes nsWindow::WindowProc(HWND__ * 0x00700426, unsigned int 273, unsigned int 40293, long 0) line 475 + 27 bytes USER32! 77e71250()
Assignee: dp → morse
Steve can you work this out. BTW, I thought all this makehtmldialog code would have gone away. mmh!
Status: NEW → ASSIGNED
This will all be fixed when a working replacement for makeHTMLdlgs becomes available.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Previously I had a very ad-hoc method of displaying html dialogs which involved invoking a 4.5 browser. I'm not at all surprised that it crashed, especially if the user didn't have a 4.5 browser in exactly the same directory as on my machine. This was all very experimental and really only for my testing purposes. The reason I was exec-ing a 4.5 browser was that the layout engine in raptor was not capable of laying out the cookie viewer correctly. I have now changed that and am using raptor itself to display the cookie viewer. Of course the display is wrong (that's the subject of bug 5410) but at least it no longer crashes. Closing out this report.
QA Contact: 3853 → 3819
Target Milestone: M5
paulmac...can you verify that this one is cool now? Thanks!
Status: RESOLVED → VERIFIED
This no longer crashes, though it doesn't seem to display anything - using 4/26 binary obtained off mozilla.org. Since viewer is just a test app, will simply mark this bug verified.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.