Closed
Bug 437381
Opened 17 years ago
Closed 7 years ago
Remove nsIJSXMLHttpRequest and fix the comments in nsIXMLHttpRequest.h
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: smaug, Assigned: emk)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file)
As far as I see, there isn't any reason for nsIJSXMLHttpRequest.
Especially after Bug 372964 things should just work like with any other event target.
Reporter | ||
Comment 1•17 years ago
|
||
Actually this could be morphed to a bug to change nsIXMLHttpRequest to be
more like XHR in XHR2 spec.
Comment 2•12 years ago
|
||
We should do this.
Comment 3•12 years ago
|
||
I left it as an empty interface for compat, but if it's not used much (which should be true), we can just nuke it.
Assignee | ||
Comment 4•12 years ago
|
||
onuploadprogress was the only member of nsIJSXMLHttpRequest. Anything depending on onuploadprogress will fail anyway.
If the interface has been merged to the parent (like nsIWindowInternal or nsILocalFile), leaving empty interface will make sense. But that is not the case here.
Comment 5•12 years ago
|
||
The concern is things doing createInstance with the nsIJSXMLHttpRequest IID passed in, then just doing normal XHR. Those places would start to throw.
For what it's worth, at least http://hg.mozilla.org/mozilla-central/file/57499abe6479/toolkit/components/url-classifier/content/xml-fetcher.js#l28 and http://hg.mozilla.org/mozilla-central/file/57499abe6479/toolkit/mozapps/extensions/nsBlocklistService.js#l516 do exactly that in our tree.
And I see 60 hits on the string "nsIJSXMLHttpRequest" in the addons mxr. All look like the same basic pattern...
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Reporter | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8896343 [details]
Bug 437381 - Remove nsIJSXMLHttpRequest and fix the comments in nsIXMLHttpRequest.h.
https://reviewboard.mozilla.org/r/167604/#review172836
Attachment #8896343 -
Flags: review?(bugs) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/7d262cd9d65a
Remove nsIJSXMLHttpRequest and fix the comments in nsIXMLHttpRequest.h. r=smaug
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 10•7 years ago
|
||
I've deleted the nsIJSXMLHttpRequest page, since it is not present in Gecko anymore.
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•