Closed
Bug 439132
Opened 16 years ago
Closed 16 years ago
removing tags from local messages sometimes doesn't survive rebuild index
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: Bienvenu, Assigned: Bienvenu)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
while working on recreating bug 380598, I noticed that removing a tag from a local message wasn't actually removing it from the x-mozilla-keys header. I'd defined a bunch of tags in my profile, as part of bug 380598, which had partly to do with the problem. Fix upcoming.
Assignee | ||
Comment 1•16 years ago
|
||
ugh, this code is truly horrible, but until it can be rewritten, this should fix the problem I was seeing. Basically, as we're iterating over the key headers in the mail message, to find the keys we want to add/remove, we need to reset the line buffer each time we seek back to the start of the message.
Attachment #325031 -
Flags: superreview?(neil)
Attachment #325031 -
Flags: review?(neil)
Updated•16 years ago
|
OS: Windows XP → All
Hardware: PC → All
Comment 2•16 years ago
|
||
Comment on attachment 325031 [details] [diff] [review]
proposed fix
I wonder why there isn't an API for that. Or maybe linebuffers suck and we need a new API ;-)
Attachment #325031 -
Flags: superreview?(neil)
Attachment #325031 -
Flags: superreview+
Attachment #325031 -
Flags: review?(neil)
Attachment #325031 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
linebuffers seem pretty barebones...
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9
Updated•16 years ago
|
Blocks: tb-tagsmeta
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•