Closed
Bug 44340
Opened 24 years ago
Closed 23 years ago
[DOCTYPE] should have stricter DOCTYPE parsing code
Categories
(Core :: DOM: HTML Parser, defect, P2)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [Hixie-P4])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I'm entering this as a bug so that the code doesn't get lost, since I've pulled
it out of my tree. I still think we should consider doing something like this
in the future, so I'm going to move this to MFuture.
The code I'm going to attach is a few functions (already slightly out of date)
that do mode selection based on strict parsing of the DOCTYPE. They go to
noquirks for unknown DTD's from 3 sources (W3C, ISO, IETF), but quirks for
unknown ones from other sources. What is done with a given set of DTDs could
easily be changed. The parsing is done as close to the SGML spec as I could
get, although there are a few things I don't handle fully.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
wont fix; pulling strictDTD support.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 4•24 years ago
|
||
Reopening. We still use doctype parsing for layout quirks.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment 5•24 years ago
|
||
Marking [DOCTYPE] for easy searching.
Summary: should have stricter DOCTYPE parsing code → [DOCTYPE] should have stricter DOCTYPE parsing code
Assignee | ||
Comment 6•24 years ago
|
||
Nominating for mozilla 0.9. I'd like to get this in (revised, due to
bug 55264) for mozilla 1.0, at it should have significant testing beforehand.
The current code is bad because it's just wrong. We should be testing equality
of doctypes, not searching the DOCTYPE's public ID for certain strings such as
numbers that we think are versions or searching the system ID for certain
strings that are currently used as the file naming conventions for storage of
DTDs in W3C specs (e.g., "strict.dtd"). While it can be demonstrated to be
correct on many common examples, we've already seen one example of serious
failure (bug 55916), and there will probably be more.
Keywords: mozilla0.9
Assignee | ||
Comment 7•24 years ago
|
||
For lack of comments from rickg, assigning to myself.
Assignee: rickg → dbaron
Severity: enhancement → major
Status: REOPENED → NEW
Priority: P3 → P1
Target Milestone: Future → mozilla0.9
Assignee | ||
Comment 8•24 years ago
|
||
I've been trying to fix this in a sensible way involving only parsing the DOCTYPE
in one place. However, the htmlparser design makes this very difficult.
Comment 9•24 years ago
|
||
Removing patch keyword based on dbaron's comments that the current patch is no
longer valid. Good luck with getting this to work :-)
Gerv
Keywords: patch
Assignee | ||
Comment 11•24 years ago
|
||
Reality check. Moving out to 0.9.1.
Target Milestone: mozilla0.9 → mozilla0.9.1
Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Comment 13•24 years ago
|
||
*** Bug 82261 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 14•24 years ago
|
||
I would still like to do this, but 0.9.2 should be a low-risk milestone, so
moving to 0.9.3. I guess we'll just ship 0.9.2 with the mess we currently have,
unless someone feels strongly that I should try to do this for 0.9.2.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Assignee | ||
Updated•23 years ago
|
Priority: P1 → P2
Comment 15•23 years ago
|
||
what's the current status?
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Assignee | ||
Comment 16•23 years ago
|
||
Patch is incorporated into the patch on bug 55264.
Assignee | ||
Comment 17•23 years ago
|
||
Fix checked in 2001-09-08 11:37 PDT (see bug 55264).
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•