Closed Bug 4436 Opened 26 years ago Closed 26 years ago

XUL on-load handler runs even if doc load fails

Categories

(Core :: XUL, defect, P3)

All
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: waterson, Assigned: danm.moz)

Details

The XUL on-load handler runs even if the document load terminated unsuccessfully. This seems wrong. See also bug 4433.
Target Milestone: M4
Targeting M4. Weren't there some null-deref bugs exposed by this?
Null deref bugs are logged as 4437.
Status: NEW → ASSIGNED
Target Milestone: M4 → M5
Target Milestone: M5 → M6
This will be fixed as fallout to one of hyatt's impending checkins, in which the workings of the entire onload event handler mechanism will be reworked. He won't be able to check that in before M5, so I'm pushing this bug off to M6 for now, anticipating the checkin.
Target Milestone: M6 → M7
Now that we're in M6, I get to move this off to M7. The aforementioned checkin has been made, but not activated. Activation depends on adoption by clients of XPFE of new window.open() functionality which is expected to obviate the need for the special callbacks which surround the current onload handler, making its behaviour different from the unactivated standard one. Adoption would mean we can switch to the new one, remove the old one, and as a side effect, fix this bug. Here's hoping to make that happen sometime in the next milestone.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Execution of JavaScript onload code has been moved from nsWebShellWindow to the standard webshell event listener mechanism. That should fix this problem.
QA Contact: gerardok → ckritzer
Changing QA Contact to ckritzer@netscape.com.
marking verified
Status: RESOLVED → VERIFIED
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.