Closed Bug 45407 Opened 24 years ago Closed 24 years ago

List Properties dialog cleanup

Categories

(Core :: DOM: Editor, defect, P4)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sujay, Assigned: cmanske)

Details

(Whiteboard: [nsbeta3+][p:4])

using 7/13 build of netscape 1) launch netscape 2) launch composer 3) click on bullet list 4) enter several items 5) click on middle of list somewhere 6) bring up Format | List properties 7) change list to numbered list it doesn't change the entire list to bullet list...just one item where you had your caret.. all platforms.
setting to m18
Target Milestone: --- → M18
b3 nomination
Status: NEW → ASSIGNED
Keywords: nsbeta3
added correctness and nsbeta3+
Keywords: correctness
Whiteboard: [nsbeta3+]
setting priority in status whiteboard
Priority: P3 → P4
Whiteboard: [nsbeta3+] → [nsbeta3+][p:4]
Charlie, I'm assigning this to you to get it on your radar. You can assign it back to me if you want. The deal is that if someone selects a list item and changes the list type from the toolbar, we just change that one list item (breaking it out into a new list). But when someone (with the same slection) chooses a new list type from the list properties dialog, they are probably trying to change the whole list. But it only changes the list item. Similarly, when Format->List->Numbered is chosen, it only changes the list item. I think the menu and dialog should affect the whole list, and only the toolbar should try to act on just the selected items. Do you agree?
Assignee: jfrancis → cmanske
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Per PDT. + to just take the List Properties menu item out completely. Nothing works, no time left at this point. beppe, can you reset to higher P level.
Whiteboard: [nsbeta3+][p:4] → [nsbeta3+][p:4][Pull menu item only!]
Whiteboard: [nsbeta3+][p:4][Pull menu item only!] → [nsbeta3+][p:4]
You are full of it. There's very minor changes needed here. We must have this dialog else list editing is a joke.
List dialog has been cleaned up and is waiting for review. Concerning the issue of changing the entire list to a type selected in the dialog, this is not easy to do because of the way the C++ list code works. It totally depends on the exact selection, so "applying" a new list type is impossible; changing list type involves inserting new list elements, moving children, etc. So the only way to do this is automatically change the selection to surround the entire list before calling the "MakeOrChangeList" method. Since changing the selection is not something we should do without user feedback, I've added radio buttons to give the user the option of changing list type for the entire list or only for selected items (like the toolbar buttons and menu items do.) Note that this option is not available if there is no existing list, or selection starts before, but extends into a list. The list properties in the dialog are those of the anchor node of the selection, even if selection spans across multiple OL, UL, or DL elements. I do not believe we should apply the list type to entire list in the menu items; generally, menu behavior should always act just like toolbar buttons. I think it's enough to give this option just in the List properties dialog. To make this more accessible, when the selection is in a list, the dynamic "Properties" item in the format menu and context popup menu will show "List Properties" so it is more accessible.
Summary: can't change entire list to another style using list properties dialog → List Properties dialog cleanup
Work is done -- waiting for review.
Whiteboard: [nsbeta3+][p:4] → [nsbeta3+][p:4][checking in 9/5]
checked in 9/5/00
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: [nsbeta3+][p:4][checking in 9/5] → [nsbeta3+][p:4]
verified in 9/6 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.