Closed
Bug 454747
Opened 16 years ago
Closed 16 years ago
optimized hook to use NullXFORM on identity color transform gives us CachedXFORM
Categories
(Core :: Graphics: Color Management, defect)
Core
Graphics: Color Management
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Vlad and I found this bug while we were trying to figure out why the reftests were failing on linux when we tried to land color management (it was backed out for the time being).
LCMS has a lot of annoying side-effects in the transform selection phase. When I tried to add code to detect if (InputProfile == OutputProfile) in the Matrix Shaper section and select NullXFORM, I ended up going around the setting of a flag that later prevents the current transform from being overridden. Thus, we ended up with a CachedXFORM, which isn't what we want.
I'll write up a patch for this tomorrow morning.
|
Assignee | |
Comment 1•16 years ago
|
||
attached a fix. Vlad and I are going to try it out on his linux box when he gets out of his meeting.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #338135 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 2•16 years ago
|
||
pushed in 22a82f07723d. Waiting for vlad to retroactively r+ the patch so that I don't look sketchy to historians. :)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Looks like vlad isn't going to retroactively r+ this patch anytime soon. Closing the bug.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #338135 -
Flags: review?(vladimir)
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
|
|
Assignee | |
Updated•16 years ago
|
Component: GFX → GFX: Color Management
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•