Closed
Bug 455787
Opened 16 years ago
Closed 16 years ago
Extract bookmarks toolbar background color to a general toolbar rule
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 obsolete file)
This is a follow-up fix to bug 449832.
> It changes two things:
> - RTL tab margins fix
> - The background and border colors of the Bookmarks toolbar are moved into a
> general rule in global/toolbar.css. The border colors are tweaked a little.
Attachment #339133 -
Flags: review?(mconnor)
Assignee | ||
Updated•16 years ago
|
Attachment #339133 -
Attachment is obsolete: true
Attachment #339133 -
Flags: review?(mconnor)
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 339133 [details] [diff] [review]
follow-up patch to fix rtl and normal toolbars
+window:not([active]) toolbar,
+window:not([active]) toolbarpalette {
+ border-top-color: rgba(255, 255, 255, 0.48);
+ background-color: -moz-mac-chrome-inactive;
+ border-bottom-color: rgba(0, 0, 0, 0.32);
}
This doesn't work correctly. toolbar.css is scoped to the toolbar binding and doesn't know anything about the window. So when the window's active state changes, the style rule isn't re-resolved and the toolbar has the wrong color.
I'll think about what to do here.
Comment 2•16 years ago
|
||
(In reply to comment #1)
> toolbar.css is scoped to the toolbar binding and
> doesn't know anything about the window. So when the window's active state
> changes, the style rule isn't re-resolved and the toolbar has the wrong color.
You can put it in global.css. Extra points for waiting for bug 459457 so that I don't have to merge :)
Updated•16 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Assignee | ||
Comment 3•16 years ago
|
||
We don't need to set a background color for toolbars when we have -moz-appearance: toolbar, which I'm implementing in bug 460899.
Resolving as invalid.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•