Closed
Bug 463745
Opened 16 years ago
Closed 16 years ago
DOMLinkAdded event
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The time for this is proportional to the number of <link...href=">. Seems that many sites have 7 more of these elements which ends up using about 100ms of cpu time.
Maybe there is a way to do this using xpath, so we don't have to do a callback per <link/> element, but I don't know anything about that.
Attachment #346996 -
Flags: review?(mark.finkle)
Comment 1•16 years ago
|
||
Comment on attachment 346996 [details] [diff] [review]
rework favicon handling.
>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> _linkAdded : function(aEvent) {
>- if (!link || !link.ownerDocument || !link.href)
>+ if (!link || !link.href || this._faviconLink )
Doesn't this mean we'll now use the first rather than the last? I don't think we want to change that.
Assignee | ||
Comment 2•16 years ago
|
||
Good point. I'll take out "|| this._faviconLink".
Comment 3•16 years ago
|
||
Comment on attachment 346996 [details] [diff] [review]
rework favicon handling.
r+ with gavin's change
Attachment #346996 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•16 years ago
|
||
pushed http://hg.mozilla.org/mobile-browser/rev/e3dbc2daf67f and http://hg.mozilla.org/mobile-browser/rev/c7fb9923d36b
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
Can someone please verify this, or provide some steps to reproduce ?
Updated•14 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•