Build 2000-07-25-09M17: NT4 Haven't checked Mac or Linux yet. Overview: In a News message, go to the Message Body/Content Area. Right click onto any area in the body with nothing specific selected. The context menu that appears should match the spec and should appear as follows: Open in New Window Select All ------------------- Reply to Sender Reply to Newsgroup Reply to All Forward Edit As New ------------------- Move To > (I think this should be removed from the spec for a News message) Copy To > Save As... Print... Delete ------------------- Add Sender to Address Book Add All To Address Book For the product to match the spec, the following should happen: 1. Remove a. "Copy" from the first section 2. Change a. "?Reply To All" should remove the question mark and appear as "Reply To All"

Looks good

per mail triage: remove nsbeta3 nomination and move to future milestone. For the short term, we will combine items here into three bugs (in 3pane) to address for nsbetat3: 1. delete, change text, move menuitems; 2. enable/disable and text changes on context (dynamic); 3. accelerator keys to work (ie. what is shown in the menus actually does something) When this bug gets revisited after the first release, we'll need to see what items remaining that need to be addressed.

Taking.

Is "Ca_ncel" supposed to be here? Intertwines with bug 83203, jglick's say needed.

Patch 38505 does the following: * Removes the "Copy" menu entirely should no selection be found * Adds the "Copy" menu should a selection be found AND the user has clicked a link or image (since there's still a selection that can be copied) Does this on both Mail and News message bodies. r/sr wanted.

Addressing the original comment: Open in New Window -- not in current spec, so left out Move To -- is in current spec, but not in current implementation and makes no sense, so left out Address Book items -- not in current implementation nor spec, so left out. Mnemonics clash in the spec (Re_ply to All | _Print). Address those in another bug.

+ if (top.frames['messagepane'].getSelection().toString().length < 1) That seems like more of a hack than a fix to me. You don't need to check the length of the string, instead check if toString() returns "" (nothing).

>Is "Ca_ncel" supposed to be here? Intertwines with bug 83203, jglick's say needed. Yes, Cancel instead of Delete for News. >Removes the "Copy" menu entirely should no selection be found >Adds the "Copy" menu should a selection be found AND the user has clicked a >link or image (since there's still a selection that can be copied) Are you adding Copy as an additional item to the existing menu below "Select All"? Shouldn't this be when there is a selection OR when the user has clicked a link or image? >Open in New Window -- not in current spec, so left out Good. Thanks. >Move To -- is in current spec, but not in current implementation and makes no >sense, so left out. Correct, shouldn't be there. >Address Book items -- not in current implementation nor spec, so left out. Good. Thanks. >Mnemonics clash in the spec (Re_ply to All | _Print). Address those in another bug. D'oh. Thought i caught all those. Lets go with "Reply _to All". Will update spec to reflect your changes. Thanks for the great work. :-)

> >Removes the "Copy" menu entirely should no selection be found > >Adds the "Copy" menu should a selection be found AND the user has clicked a > >link or image (since there's still a selection that can be copied) > Are you adding Copy as an additional item to the existing menu below "Select > All"? Yes. > Shouldn't this be when there is a selection OR when the user has clicked a > link or image? Undefined. In the specs you deal with selection, and links, but not both at the same time :). For example, if you have a paragraph with a link in the middle, and you selected the entire paragraph, you can either right-click on the link or not. Either way, there is still a selection to be copied, and if you happen to have clicked over the link the "Copy Link Location" option is there for that link specifically. IMO, the specs should be changed to say that if you have a selection and you are right-clicking over a link or image, the "Copy" menu and "Select All" menus should still be present as it is quite possible/probable that those options are the ones the user wants. I can change this behaviour quickly if you really only want "Copy" to appear on selection and NOT on link/image.

What you said seems correct. :-) User specifically selects content in the message body, which may or may not include Text, Links, Images, etc. Then Copy is included in the context menu below "Select All". If user invokes content menu directly over a link or image, regardless of whether paragraph of text is selected or not, they should get "Copy Link" or "Copy Image" as appropriate.

please seriously consider |if (!top.frames['messagepane'].getSelection().toString())| and is there any way to avoid toString()? it would appear to be rather expensive given all you need to know is if there is a selection.

Patch 38741 does the following: * Removes "Copy" if no selection is present * Adds "Copy" is there is a selection and pointer is over plain text or whitespace. If you want "Copy" present if the pointer is over a link or image too, please state so in bug 46485. * "Can_cel" becomes "Ca_ncel" to avoid conflict * In Messages drop-down as well as context menu, "Re_ply to All" becomes "Reply _to All" to avoid conflict * Uses |.getSelection.isCollapsed| instead of a comparison per smfr's optimisation advice. I bow to his knowledge. Looking for r/sr again.

r=fabian great job jmkg!

CC bienvenu for sr.

*** Bug 83203 has been marked as a duplicate of this bug. ***

*** Bug 46483 has been marked as a duplicate of this bug. ***

Darn, bienvenu went on vacation. CC Seth for the sr=.

I think the patch in bug 72611 should go in first, and an updated patch attached here.

*** Bug 88773 has been marked as a duplicate of this bug. ***

Note to check the Mail vs News specific items when verifying this bug.

Missed the 0.9.3 train.

looks like it didn't make the 0.9.4 train. have a look an get a good milestone assigned... thanks -chofmann

Should get to this next week.

status?

Bouncing out, hope someone with more time than I catches.

Only remaining issue is that the Copy menu item is disabled instead of hidden. Closing as FIXED. File a new bug if you think the menu item should be hidden instead.