Closed Bug 46537 Opened 24 years ago Closed 23 years ago

URL: illegal schemes do not error in "Open Web Location"

Categories

(Core :: DOM: Navigation, defect, P4)

x86
Linux
defect

Tracking

()

VERIFIED DUPLICATE of bug 89118
mozilla1.0.1

People

(Reporter: otto, Assigned: adamlock)

References

Details

(Keywords: helpwanted, qawanted)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.14-5.0 i686; en-US; m17) Gecko/20000726 BuildID: 2000072608 Going to a page with a semi-bogus protocol in the URL fails sliently. For example, +http://www.mozilla.org never gives an error message. asdf://www.mozilla.org does say there is no registered protocol. It seems to be the punctuation that does it, xhttp fails as expected but pretty much any punctuation preceding 'http' causes it (tried, +=!.,) Reproducible: Always Steps to Reproduce: 1. Open the "Open Web Location..." window. 2. Type +http://www.mozilla.org 3. Actual Results: The "Open Web Location..." window closes. Nothing else happens. Expected Results: The same behavior if you specify asdf://www.mozilla.org
Does exactly the same for me using a build from 2000-Jul-26.
URL resolution, Networking.
Assignee: asa → gagan
Component: Browser-General → Networking
QA Contact: doronr → tever
Target Milestone: --- → Future
Blocks: 61999
The function ExtractURLScheme inside nsURLHelper.cpp correctly reports an NS_ERROR_MALFORMED_URI in the described cases because an url has to start with an ascii char. If you type asdf:... the scheme is correctly extracted by the function and later detected to be invalid. One can only assume that NS_ERROR_MALFORMED_URI is silently ignored inside the webshell.
This problem also occurs for valid urls but that literally aren't registered. A url such as http://www.thisisnotregistered.org/ also fails silently. Mozilla0.9 nomination. There is no feedback given to the user on failure.
Keywords: mozilla0.9
mass move, v2. qa to me.
QA Contact: tever → benc
Good catch, I don't think the average person knows what characters are valid, so this would be good to catch.
Keywords: nsCatFood
Summary: Bogus URL fails silently. → URL: illegal schemes do not error
Narrowing scope of this b/c bug 86486 is for HREF URL's. Cut and paste of invalid schemes into the URL field and hitting return seems to error correctly.
Keywords: mozilla0.9.2
Summary: URL: illegal schemes do not error → URL: illegal schemes do not error in "Open Web Location"
Gagan: since the errors come back correctly in some entry points, isn't this someone else's code talking to Necko that needs to trap the error?
Keywords: helpwanted, qawanted
It is and should be handled by whoever is invoking that dialog. Over to vishy since I believe this is in his group...
Assignee: gagan → vishy
Target Milestone: Future → ---
Keywords: nsCatFoodnsCatFood+
Priority: P3 → P4
Target Milestone: --- → mozilla1.0.1
Seems to me that front end puts up dialog fine, but some just aren't invoking it. Looks like that logic is in docshell, ->adamlock
Assignee: vishy → adamlock
Keywords: mozilla0.9.2
Duping this against bug 81998 where I've submitted a patch for the malformed URI stuff for anyone who'd like to review it. The other stuff about http://www.thisisnotregistered.org/ has worked for a long time now. *** This bug has been marked as a duplicate of 89118 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
-> docshell, reset qa.
Component: Networking → Embedding: Docshell
QA Contact: benc → adamlock
V/fixed: Seamonkey 1.1.9, Mac OS X. NOTE: this menu item is not in Firefox 3.
Status: RESOLVED → VERIFIED
QA Contact: adamlock → benc
You need to log in before you can comment on or make changes to this bug.