Closed
Bug 469085
Opened 16 years ago
Closed 16 years ago
Add manifest to 7zSD.sfx
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a2
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
(deleted),
patch
|
mcsmurf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
application/octet-stream
|
Details |
This has been done for Firefox / Thunderbird and I thought Seamonkey as well. It should contain the following... this will launch the 7-zip stub without elevation on Vista and then NSIS will request elevation.
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity version="1.0.0.0" processorArchitecture="X86" name="7zS.sfx.exe" type="win32"></assemblyIdentity>
<description>7-Zip Self-extracting Archive v4.42</description>
<dependency>
<dependentAssembly>
<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="X86" publicKeyToken="6595b64144ccf1df" language="*"></assemblyIdentity>
</dependentAssembly>
</dependency>
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"><security><requestedPrivileges><requestedExecutionLevel level="asInvoker" uiAccess="false"></requestedExecutionLevel></requestedPrivileges></security>
</trustInfo>
</assembly>
Assignee | ||
Comment 1•16 years ago
|
||
Frank, could I get you to review this? To see the change to the binary you'll need reshacker ( http://www.angusj.com/resourcehacker/ ) and the addition is resource 24. I'll also attach the binary.
Assignee: installer → robert.bugzilla
Attachment #352499 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•16 years ago
|
||
Updated•16 years ago
|
Attachment #352499 -
Flags: review?(bugzilla) → review+
Comment 3•16 years ago
|
||
Comment on attachment 352499 [details] [diff] [review]
patch
Oh right, I forgot to change the manifest to match the new installer code. Patch looks good and seems to work fine, r+.
Assignee | ||
Comment 4•16 years ago
|
||
Frank, shall I land this on both trunk and 1.9.1?
Comment 5•16 years ago
|
||
Yeah, do it that way.
Assignee | ||
Comment 6•16 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/23e4c322ac1bd3b57e9b6893165dad348699ca4f
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3cf1487f59ab
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a2
You need to log in
before you can comment on or make changes to this bug.
Description
•