Closed
Bug 471722
Opened 16 years ago
Closed 16 years ago
Plaintext editor redo handling code looks for incorrect type of bogus node
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: graememcc, Assigned: graememcc)
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b3])
Attachments
(3 files, 4 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
From http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/editor/libeditor/text/nsTextEditRules.cpp&rev=HEAD&mark=1.211, revision 1.73 (which seems to correspond to bug 16905) the "bogus node" type was changed from a <div> to <br>.
When checking to see if a bogus node reappeared after redo, we're still looking for divs...
Attachment #354977 -
Flags: superreview?(peterv)
Attachment #354977 -
Flags: review?(peterv)
Comment 1•16 years ago
|
||
Comment on attachment 354977 [details] [diff] [review]
Trivial fix
Sigh. I guess we don't really know how to test this?
Attachment #354977 -
Flags: superreview?(peterv)
Attachment #354977 -
Flags: superreview+
Attachment #354977 -
Flags: review?(peterv)
Attachment #354977 -
Flags: review+
Assignee | ||
Comment 2•16 years ago
|
||
Would something like this be a suitable test?
It fails against current trunk, after the redo, the textbox's value = "\n" rather than "".
Attachment #355475 -
Flags: superreview?(peterv)
Attachment #355475 -
Flags: review?(peterv)
Assignee | ||
Comment 3•16 years ago
|
||
Comment on attachment 355475 [details] [diff] [review]
Patch with possible mochitest
Er, the second patch shouldn't need sr, as I already have it from the first patch, and this is just a review request for the test.
Attachment #355475 -
Flags: superreview?(peterv)
Assignee | ||
Comment 4•16 years ago
|
||
Might as well try to get the fix in for baking. The test can follow.
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Attachment #360975 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: Please checkin "hg export for checkin"
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #355475 -
Attachment is obsolete: true
Attachment #360977 -
Flags: review?(peterv)
Attachment #355475 -
Flags: review?(peterv)
Updated•16 years ago
|
Attachment #360975 -
Attachment is patch: true
Comment 6•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: Please checkin "hg export for checkin"
Target Milestone: --- → mozilla1.9.2a1
Updated•16 years ago
|
Attachment #360977 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 7•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: please check in mochitest patch
Updated•16 years ago
|
Attachment #360975 -
Attachment description: hg export for checkin → hg export for checkin
[Checkin: Comment 6]
Updated•16 years ago
|
Attachment #354977 -
Attachment is obsolete: true
Updated•16 years ago
|
Attachment #360977 -
Attachment is obsolete: true
Comment 8•16 years ago
|
||
Comment on attachment 362309 [details] [diff] [review]
[Test] hg export for checkin
[Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/e6daa019b2ca
Attachment #362309 -
Attachment description: [Test] hg export for checkin → [Test] hg export for checkin
[Checkin: Comment 8]
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Whiteboard: please check in mochitest patch
Assignee | ||
Comment 9•16 years ago
|
||
Requesting approval - very minor fix to correct the existing logic. Fixes a case where "redo" in textboxes has been broken since 1999!
Attachment #362432 -
Flags: approval1.9.1?
Updated•16 years ago
|
Attachment #362432 -
Flags: approval1.9.1? → approval1.9.1+
Comment 10•16 years ago
|
||
Comment on attachment 362432 [details] [diff] [review]
Combined patch for branch
a1.9.1=dbaron
Assignee | ||
Comment 11•16 years ago
|
||
Attachment #362432 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: Please checkin branch patch to 1.9.1
Comment 12•16 years ago
|
||
Comment on attachment 364307 [details] [diff] [review]
hg export for branch checkin
[Checkin: Comment 12]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fd629d7e3122
Attachment #364307 -
Attachment description: hg export for branch checkin → hg export for branch checkin
[Checkin: Comment 12]
Updated•16 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: Please checkin branch patch to 1.9.1 → [fixed1.9.1b3]
The test case for this bug has a bogus </head> tag in place of </title>. See bug 546256.
You need to log in
before you can comment on or make changes to this bug.
Description
•