Closed Bug 4756 Opened 26 years ago Closed 26 years ago

Worrisome warnings from SGI/native in xpconnect

Categories

(Core :: XPConnect, defect, P3)

SGI
IRIX
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: tor, Assigned: jband_mozilla)

Details

Compiling on an SGI with the native compiler (MIPSpro 7.2.1.3m), the compiler gives some rather nasty warnings: "/cs/src/mozilla/mozilla/js/src/xpconnect/src/xpcwrappednativeclass.cpp", line 361: warning(3150): class "nsXPTType" has no copy assignment operator. A copy assignment operator of the form: function "nsXPTType::operator=(const nsXPTType &)" has been implicitly defined. The implicitly defined copy assignment operator will perform a bitwise copy. Previous compiler versions may have used assignment operator functions defined in this class with conversion operators as copy assignment operator. This change may lead to different runtime behavior. Define a copy assignment operator if necessary. v.type = constant->GetType(); ^ "/cs/src/mozilla/mozilla/js/src/xpconnect/src/xpcwrappednativeclass.cpp", line 448: warning(3150): class "nsXPTType" has no copy assignment operator. A copy assignment operator of the form: function "nsXPTType::operator=(const nsXPTType &)" has been implicitly defined. The implicitly defined copy assignment operator will perform a bitwise copy. Previous compiler versions may have used assignment operator functions defined in this class with conversion operators as copy assignment operator. This change may lead to different runtime behavior. Define a copy assignment operator if necessary. dp->type = type; ^
Assignee: norris → jband
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
The shallow copy was perfectly adequate for this flyweight wrapper class whose only data is an 8bit unsigned integer. I added an overloaded assignment operator anyway to make the pedantic compiler happy. This will get checked in after M4 is out.
Javacsript component begin retired. Moving this bug to Javascript Engine.
Component: Javascript Engine → XPConnect
tor, would you change the status to VERIFIED if you are able to build without worrisome warnings? thanks!
You need to log in before you can comment on or make changes to this bug.