Closed
Bug 478939
Opened 16 years ago
Closed 16 years ago
listboxes should support three finger swipe up/down on Mac OS X
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
beltzner
:
approval1.9.1-
|
Details | Diff | Splinter Review |
Swipe up/down to jump to the top and bottom of the list. Used in places like uh.. View -> Character Encoding -> Customize List...
|
Assignee | |
Comment 1•16 years ago
|
||
|
||
Comment 2•16 years ago
|
||
Comment on attachment 362766 [details] [diff] [review]
v1
OK, although an error will occur when the list is empty due to bug 420424.
Attachment #362766 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Comment 4•16 years ago
|
||
So what's the reason for the code duplication in richlistbox.xml and listbox.xml?
richlistbox extends the listbox-base binding, but this handler is in the listbox binding, and richlistbox got its own handler in bug 478607.
|
||
Comment 5•16 years ago
|
||
I think we should better handle this in bug 478607. Perhaps reopening bug 478607 due to follow-up fix?
|
|
Assignee | |
Comment 6•16 years ago
|
||
Part of the reason for a separate richlistbox implementation was that richlistitems can contain anything of varying size and styles -- potentially display: none;
But sure, perhaps it would be better to have it shared.
|
|
||
Comment 7•16 years ago
|
||
That's awesome! Verified fixed on 1.9.1 branch with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633
Status: RESOLVED → VERIFIED
|
|
||
Comment 8•16 years ago
|
||
Edward, is this patch ready for 1.9.1?
|
|
||
Updated•16 years ago
|
Attachment #362766 -
Flags: approval1.9.1?
|
||
Comment 9•16 years ago
|
||
Comment on attachment 362766 [details] [diff] [review]
v1
Mardak: can you get a test together and renominate? Gavin can show you how if you need help.
Attachment #362766 -
Flags: approval1.9.1? → approval1.9.1-
You need to log in
before you can comment on or make changes to this bug.
Description
•