Open
Bug 479945
Opened 16 years ago
Updated 12 years ago
non-ASCII characters should be decoded in the Bookmarks dialogs
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
NEW
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
()
Details
(Whiteboard: [2012 Fall Equinox])
Attachments
(1 file)
(deleted),
patch
|
neil
:
review-
neil
:
superreview-
|
Details | Diff | Splinter Review |
This is a Bookmarks part of bug 425480. I think i covered all cases.
Attachment #363853 -
Flags: superreview?(neil)
Attachment #363853 -
Flags: review?(neil)
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → misak
Status: NEW → ASSIGNED
Updated•16 years ago
|
Attachment #363853 -
Flags: superreview?(neil)
Attachment #363853 -
Flags: superreview-
Attachment #363853 -
Flags: review?(neil)
Attachment #363853 -
Flags: review-
Comment 1•16 years ago
|
||
Comment on attachment 363853 [details] [diff] [review]
patch
>- url = getNormalizedURL(gFld_URL.value);
>+ url = encodeURI(gFld_URL.value);
>+ url = getNormalizedURL(url);
There are two problems here:
1. getNormalizedURL needs to run on the value, since its job is to convert a local file path into a URI
2. encodeURI reencodes everything, which breaks already encoded URIs.
3. bookmark keywords need to be able to support %s and %S in bookmark values.
Is it actually necessary to encode the URI here? Presumably the encoded URI will still work when loaded as a URI.
>+ document.getElementById("url").value = BookmarksUtils.losslessDecodeURL(document.getElementById("url").value);
>+
I don't think this change is right.
>+ losslessDecodeURL: function (value)
Should comment that this function is similar to the one in navigator.js (or modify navigator.js to call this version perhaps?)
Comment 2•16 years ago
|
||
Erm, or move the navigator version to utilityOverlay.js perhaps?
Or a JSM module?
Assignee | ||
Updated•15 years ago
|
Depends on: SMPlacesBMarks
Comment 3•14 years ago
|
||
Should be fixed by bug 498596 in current nightlies, SeaMonkey 2.1 Alpha 3 and later - please double-check in such builds.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•14 years ago
|
||
It's not fixed, location column still show urls like http://ru.wikipedia.org/wiki/%D0%92%D0%BE%D0%B5%D0%BD%D0%BD%D0%B0%D1%8F_%D0%B1%D0%B0%D0%B7%D0%B0_%D0%93%D1%83%D0%B0%D0%BD%D1%82%D0%B0%D0%BD%D0%B0%D0%BC%D0%BE
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Problem still present, in both History and Bookmarks location shows http://ru.wikipedia.org/wiki/%D0%92%D0%BE%D0%B5%D0%BD%D0%BD%D0%B0%D1%8F_%D0%B1%D0%B0%D0%B7%D0%B0_%D0%93%D1%83%D0%B0%D0%BD%D1%82%D0%B0%D0%BD%D0%B0%D0%BC%D0%BE instead of http://ru.wikipedia.org/wiki/Военная база Гуантанамо
Whiteboard: [2012 Fall Equinox]
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•