Closed
Bug 481340
Opened 16 years ago
Closed 16 years ago
navigator.js : "Warning: assignment to undeclared variable value"
Categories
(SeaMonkey :: Location Bar, defect)
SeaMonkey
Location Bar
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: sgautherie, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
misak.bugzilla
:
review+
misak.bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
+http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)
{
Warning: assignment to undeclared variable value
Source File: chrome://navigator/content/navigator.js
Line: 1860
}
Missing |var| in
http://hg.mozilla.org/comm-central/rev/7f5a9e84aa8a
Flags: in-testsuite-
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #365400 -
Flags: superreview?(neil)
Attachment #365400 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #365400 -
Flags: superreview?(neil)
Attachment #365400 -
Flags: superreview+
Attachment #365400 -
Flags: review?(neil)
Attachment #365400 -
Flags: review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 365400 [details] [diff] [review]
fix
No need to give it a value(!) here, since it always gets one later.
|
Reporter | |
Comment 3•16 years ago
|
||
Comment on attachment 365400 [details] [diff] [review]
fix
>+ var value = "";
No need for a default value.
Attachment #365400 -
Flags: superreview?(neil)
Attachment #365400 -
Flags: superreview+
Attachment #365400 -
Flags: review?(neil)
Attachment #365400 -
Flags: review+
|
|
Reporter | |
Comment 4•16 years ago
|
||
Comment on attachment 365400 [details] [diff] [review]
fix
Sorry Neil, I shouldn't have validated that mid'air collision :-<
|
|
||
Updated•16 years ago
|
Attachment #365400 -
Flags: superreview?(neil)
Attachment #365400 -
Flags: superreview+
Attachment #365400 -
Flags: review?(neil)
Attachment #365400 -
Flags: review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
carrying forward r+ sr+ from Neil
Attachment #365400 -
Attachment is obsolete: true
Attachment #365407 -
Flags: superreview+
Attachment #365407 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
|
Reporter | |
Comment 6•16 years ago
|
||
Comment on attachment 365407 [details] [diff] [review]
for checkin
[Checkin: Comment 6]
http://hg.mozilla.org/comm-central/rev/0c9fa2b7a595
Attachment #365407 -
Attachment description: for checkin → for checkin
[Checkin: Comment 6]
|
|
Reporter | |
Updated•16 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•