+++ This bug was initially created as a clone of Bug #441716 +++ ***** { http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1236938445.1236945621.23070.gz Linux mozilla-central unit test on 2009/03/13 03:00:45 *** 1336 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul | Error thrown during test: this.mDownload is null - got 0, expected 1 }

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238103694.1238109620.9809.gz Linux mozilla-central unit test on 2009/03/26 14:41:34

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238193473.1238201108.6302.gz Linux mozilla-central unit test on 2009/03/27 15:37:53 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238200673.1238208561.23458.gz Linux mozilla-central unit test on 2009/03/27 17:37:53 http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238205926.1238214332.9117.gz Linux mozilla-central unit test on 2009/03/27 19:05:26

This test looks fairly broken... nothing ever sets mDownload? On the mac where this passed, the log shows: *** 1339 INFO Running chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul... domwindowopened callback - not pausing or resuming *** 1340 INFO TEST-PASS | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul | Download Manager UI is not showing So I think we're just getting different ordering of events here. I'm going to disable this test.

Test disabled: https://hg.mozilla.org/mozilla-central/rev/355502299a99

Could you disable on 1.9.1 as well? http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1239025497.1239031758.16789.gz#err0

(In reply to comment #4) > Test disabled: > https://hg.mozilla.org/mozilla-central/rev/355502299a99 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/290370c26b83 After fixing context for { patching file toolkit/mozapps/downloads/tests/chrome/Makefile.in Hunk #1 FAILED at 40 1 out of 1 hunks FAILED }

(In reply to comment #6) > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/290370c26b83 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/246126a8d30b (bad merge fix)

Skipping the test (comment 7) is good enough for 1.9.1.x. If you want a more complete fix, please request approval on an appropriate patch.

The test will be removed in bug 1253585.