Closed
Bug 483370
Opened 16 years ago
Closed 16 years ago
Buttons on Security tab are broken when windows are already open
Categories
(Firefox :: Page Info Window, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: bugzilla, Assigned: dao)
References
Details
(Keywords: regression, verified1.9.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
On the Security tab of Page Info, the "View Cookies" and "View Saved Passwords" buttons do not work if the Cookie Manager and the Password Manager are already open. This appears to be a regression from bug 449661 and bug 449664, which removed the setFilter() functions that are used in security.js. This has been tested using the latest 3.1/3.5 nightly on WinXP:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090313 Shiretoko/3.1b4pre
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → dao
Flags: blocking-firefox3.1?
OS: Windows XP → All
Hardware: x86 → All
|
||
Comment 1•16 years ago
|
||
I could take care of this as well.
|
|
Assignee | |
Comment 2•16 years ago
|
||
Thanks, I already have the patch.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #367392 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 4•16 years ago
|
||
I forgot to also use setFilter in cookies.js, to avoid code duplication.
Attachment #367392 -
Attachment is obsolete: true
Attachment #367395 -
Flags: review?(mconnor)
Attachment #367392 -
Flags: review?(mconnor)
|
||
Updated•16 years ago
|
Severity: minor → normal
Status: NEW → ASSIGNED
|
||
Updated•16 years ago
|
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review connor]
|
||
Comment 6•16 years ago
|
||
Comment on attachment 367395 [details] [diff] [review]
patch v2
I don't think we needed to change all of the whitespace around, but if you're dropping the curly braces it'd mess up blame anyway.
>-function _filterPasswords()
>-{
>+function _filterPasswords() {
leave this change out, you're just messing with blame.
r=me with that.
Attachment #367395 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 7•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/83f0470b40fa
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8be577118922
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Whiteboard: [needs review connor]
Target Milestone: --- → Firefox 3.2a1
|
||
Comment 8•16 years ago
|
||
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090318 Shiretoko/3.5b4pre and the latest Vista nightly. Adding keyword.
Keywords: fixed1.9.1 → verified1.9.1
|
|
||
Comment 9•16 years ago
|
||
Verified fixed on trunk too with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090318 Minefield/3.6a1pre ID:20090318030831
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090318 Minefield/3.6a1pre ID:20090318052249
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•