mozilla/modules/oji/src/nsJVMManager.cpp includes the private NSPR header primpl.h. It shouldn't. Because of this, nsJVMManager.cpp does not compile on Solaris 7. This is reported by vdemarco@novazen.com in Bugzilla bug #4761. primpl.h should not be included by files outside of NSPR. I suspect that nsJVMManager.cpp doesn't need primpl.h at all.

Removing primpl.h doesn't compile on Windows. Is xp_path.h an acceptable substitute? Chris Yeh says this is potentially obsolete.

xp_path.h was my invention. Before, many files included primpl.h just to get the definitions of a few path-related macros (PR_PATH_SEPARATOR, PR_DIRECTORY_SEPARATOR, etc.) I moved the definitions of these path-related macros to the new file xp_path.h so that those files didn't need to include primpl.h. So nsJVMManager.cpp can include xp_path.h. If later there's a replacement for xp_path.h, we will modify nsJVMManager.cpp as well as many other files to include that more appropriate header.

-> M6

Now using xp_path.h. Fixed in v1.19.

Developer defect marking verified.