Bug 481926 broke our static trunk builds. I think the issue is that as we link statically, we need to add QCMS_LIBS to our library list for linking against. However, I think to do that means we need to get the comm-central system to know about QCMS which means porting the build config changes from bug 481926 to comm-central. What I'm then concerned with is are we going to need a clever set of MOZILLA_1_9_1_BRANCH ifdefs or are we getting to the time when we need to branch? Gozer, could you take a look at how simple or complex the solution may be? Start of log: nsStaticComponents.cpp /tools/gcc-4.1.1/bin/g++ -o nsStaticComponents.o -c -I../../mozilla/dist/include/system_wrappers -include /buildbot/comm-central-trunk-linux/build/mozilla/config/gcc_hidden.h -DTHUNDERBIRD_ICO=\"../../mozilla/dist/branding/thunderbird.ico\" -DAB_CD=en-US -DGRE_MILESTONE=1.9.2a1pre -DGRE_BUILDID=20090407104313 -DAPP_EULA_BLOCK=/buildbot/comm-central-trunk-linux/build/mail/app/app-license.html -DOFFICIAL_BUILD=1 -DMOZILLA_INTERNAL_API -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux2.6.18-92.1.13\" -DOSARCH=Linux -D_BUILD_STATIC_BIN=1 -DMOZILLA_OFFICIAL -DIMPL_XREAPI -DAPP_VERSION="3.1a1pre" -DAPP_UA_NAME="Shredder" -I/buildbot/comm-central-trunk-linux/build/mozilla/toolkit/xre -I/buildbot/comm-central-trunk-linux/build/config -I/buildbot/comm-central-trunk-linux/build/mail/app -I. -I../../mozilla/dist/include/xpcom -I../../mozilla/dist/include/string -I../../mozilla/dist/include/xulapp -I../../mozilla/dist/include/xpcom -I../../mozilla/dist/include/string -I../../mozilla/dist/include -I../../mozilla/dist/include `../../mozilla/nsprpub/config/nspr-config --prefix=../../mozilla/dist --includedir=../../mozilla/dist/include/nspr --cflags` -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -gstabs+ -fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/nsStaticComponents.pp nsStaticComponents.cpp /tools/gcc-4.1.1/bin/g++ -o thunderbird-bin -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -gstabs+ -fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 nsMailApp.o nsStaticComponents.o -lpthread -Wl,-rpath-link,../../mozilla/dist/bin:/usr/lib:/usr/local/lib:/lib -L../../mozilla/dist/bin -L../../mozilla/dist/lib ../../mozilla/toolkit/xre/libxulapp_s.a -L../../mozilla/staticlib -L../../mozilla/dist/bin -lmozjs -L../../mozilla/dist/bin -lxpcom -lxpcom_core `../../mozilla/nsprpub/config/nspr-config --prefix=../../mozilla/dist --libdir=../../mozilla/dist/lib --libs` -L/lib -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgmodule-2.0 -ldl -lgobject-2.0 -lglib-2.0 -lX11 -L/lib -ldbus-glib-1 -ldbus-1 -lglib-2.0 -Wl,--whole-archive -ljemalloc -Wl,--no-whole-archive -ldl -lm ../../mozilla/staticlib/components/libpref.a ../../mozilla/staticlib/components/libuconv.a ../../mozilla/staticlib/components/libucvmath.a ../../mozilla/staticlib/components/libi18n.a ../../mozilla/staticlib/components/libnecko.a ../../mozilla/staticlib/components/libauth.a ../../mozilla/staticlib/components/libxpconnect.a ../../mozilla/staticlib/components/libchardet.a ../../mozilla/staticlib/components/libzipwriter.a ../../mozilla/staticlib/components/libmork.a ../../mozilla/staticlib/components/libcookie.a ../../mozilla/staticlib/components/libpermissions.a ../../mozilla/staticlib/components/libstoragecomps.a ../../mozilla/staticlib/components/librdf.a ../../mozilla/staticlib/components/libcaps.a ../../mozilla/staticlib/components/libhtmlpars.a ../../mozilla/staticlib/components/libgkgfxthebes.a ../../mozilla/staticlib/components/libimglib2.a ../../mozilla/staticlib/components/libgkplugin.a ../../mozilla/staticlib/components/libwidget_gtk2.a ../../mozilla/staticlib/components/libtxmgr.a ../../mozilla/staticlib/components/libcomposer.a ../../mozilla/staticlib/components/libgklayout.a ../../mozilla/staticlib/components/libdocshell.a ../../mozilla/staticlib/components/libembedcomponents.a ../../mozilla/staticlib/components/libwebbrwsr.a ../../mozilla/staticlib/components/libnsappshell.a ../../mozilla/staticlib/components/libuniversalchardet.a ../../mozilla/staticlib/components/libaccessibility.a ../../mozilla/staticlib/components/libchrome.a ../../mozilla/staticlib/components/libmozfind.a ../../mozilla/staticlib/components/libintlapp.a ../../mozilla/staticlib/components/libwindowds.a ../../mozilla/staticlib/components/libxpautocomplete.a ../../mozilla/staticlib/components/libremoteservice.a ../../mozilla/staticlib/components/libfileview.a ../../mozilla/staticlib/components/libtkautocomplete.a ../../mozilla/staticlib/components/libcommandlines.a ../../mozilla/staticlib/components/libtoolkitcomps.a ../../mozilla/staticlib/components/libspellchecker.a ../../mozilla/staticlib/components/libunixproxy.a ../../mozilla/staticlib/components/libpipboot.a ../../mozilla/staticlib/components/libpipnss.a ../../mozilla/staticlib/components/libpippki.a ../../mozilla/staticlib/components/libautoconfig.a ../../mozilla/staticlib/components/libsystem-pref.a ../../mozilla/staticlib/components/libmozldap.a ../../mozilla/staticlib/components/libimport.a ../../mozilla/staticlib/components/libmsgsmime.a ../../mozilla/staticlib/components/libmail.a ../../mozilla/staticlib/components/libmailcomps.a ../../mozilla/staticlib/libmozreg_s.a ../../mozilla/staticlib/libunicharutil_s.a ../../mozilla/staticlib/libucvutil_s.a ../../mozilla/staticlib/libgtkxtbin.a ../../mozilla/staticlib/libthebes.a ../../mozilla/staticlib/libgfxshared_s.a ../../mozilla/staticlib/libgfxpsshar.a ../../mozilla/staticlib/libgkgfx.a ../../mozilla/staticlib/libmimecthglue_s.a -L../../mozilla/modules/libimg/png -lmozpng -L../../mozilla/jpeg -lmozjpeg -L../../mozilla/modules/zlib/src -lmozz -L../../mozilla/dist/bin -lmozlcms -L../../mozilla/dist/bin -L../../mozilla/dist/lib -lcrmf -lsmime3 -lssl3 -lnss3 -lnssutil3 -lsoftokn3 -L../../mozilla/dist/bin -L../../mozilla/dist/lib -lldap60 -lprldap60 -lldif60 ../../mozilla/gfx/cairo/cairo/src/libmozcairo.a ../../mozilla/gfx/cairo/libpixman/src/libmozlibpixman.a -lXrender -lfreetype -lfontconfig -lXt -lgthread-2.0 -L/lib -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 -L../../mozilla/dist/lib -lsqlite3 ../../mozilla/staticlib/components/libimglib2.a(nsPNGDecoder.o): In function `PNGGetColorProfile(png_struct_def*, png_info_struct*, int, qcms_data_type*, unsigned int*)': /buildbot/comm-central-trunk-linux/build/mozilla/modules/libpr0n/decoders/png/nsPNGDecoder.cpp:416: undefined reference to `qcms_profile_from_memory' /buildbot/comm-central-trunk-linux/build/mozilla/modules/libpr0n/decoders/png/nsPNGDecoder.cpp:418: undefined reference to `qcms_profile_get_color_space' /buildbot/comm-central-trunk-linux/build/mozilla/modules/libpr0n/decoders/png/nsPNGDecoder.cpp:432: undefined reference to `qcms_profile_release' /buildbot/comm-central-trunk-linux/build/mozilla/modules/libpr0n/decoders/png/nsPNGDecoder.cpp:473: undefined reference to `qcms_profile_create_rgb_with_gamma'

I forgot to reference the actual changeset: http://hg.mozilla.org/mozilla-central/rev/eae0178c3e15

FWIW, the plan is to get QCMS into 1.9.1.

Yeah, qcms is going into 1.9.1, and quite possibly into 1.9.0 as well.

(In reply to comment #3) > Yeah, qcms is going into 1.9.1, and quite possibly into 1.9.0 as well. Any idea on rough timescale? If its a few days we could possibly cope with broken trunk boxes.

From Bug 481926 Comment #68, philor's 2 patches worked, and I was able to build static against trunk successfully.

This patch correctly tells the difference between trunk and 1.9.1, switching from lcms to qcms. Tested on linux.

Comment on attachment 371916 [details] [diff] [review] autodetect lcms or qcms based on mozilla-central branch r=me. I've landed this on comm-central already so we can clear the bustages: http://hg.mozilla.org/comm-central/rev/39818eecd897

Calling this fixed now that builds are starting to go green.

Realling fixed ? So why can I see this problem ? See bug 488019.

Reverted (or inverted, or something, "dumped the lcms parts that were in the 1.9.1 ifdefs") in http://hg.mozilla.org/comm-central/rev/2ba40cd789ec as a bustage fix, since qcms landed on 1.9.1.

http://hg.mozilla.org/comm-central/rev/523018b1e357 (Cv1) Remove LCMS_VERSION leftover; (no review) Noticed while working on bug 496236.

(In reply to comment #11) > http://hg.mozilla.org/comm-central/rev/523018b1e357 > (Cv1) Remove LCMS_VERSION leftover; (no review) > > Noticed while working on bug 496236. Serge, all changes must have review. We do not have exclusions except in rare instances e.g. build bustages (and then for very minor fixes only). Getting a two-minute review or rs from someone over irc would have been acceptable in this case. That said, retrospective rs=Standard8 for this change only.

(In reply to comment #12) > Serge, all changes must have review. We do not have exclusions except in rare > instances e.g. build bustages (and then for very minor fixes only). Getting a Well, it seemed so obvious, given this bug history (including your review) ... > two-minute review or rs from someone over irc would have been acceptable in > this case. ... and I have had mixed results with irc :-|