Closed
Bug 488955
Opened 16 years ago
Closed 16 years ago
iCCP PNG images render as white or incorrect colored square.
Categories
(Core :: Graphics: Color Management, defect, P1)
Core
Graphics: Color Management
Tracking
()
VERIFIED
FIXED
People
(Reporter: phiw2, Assigned: jrmuizel)
References
()
Details
(Keywords: regression, verified1.9.1)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
joe
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
test case: http://libpng.org/pub/png/colorcube/colorcube-pngs-iCCP-CSS.html
AR: Most image squares are blank, some colors display correctly, some barely look like the surrounding background color
ER: color of images match the background color (css).
This is a regression from bug 481926.
gfx.color_management.mode set to 1 or 2 (default).
Gecko 1.9.0.x with color management turned on rendered this correctly
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090417 Minefield/3.6a1pre
Flags: wanted1.9.1?
Flags: blocking1.9.1?
Comment 1•16 years ago
|
||
Do we need to fix this for b4? How many sites is it likely to affect?
Reporter | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> Do we need to fix this for b4? How many sites is it likely to affect?
Probably not many 'real world' websites. Experimental sites, who knows.
It would be good to have this kind of thing fixed before final though. The page used to display correctly.
Assignee | ||
Comment 3•16 years ago
|
||
Assignee: nobody → jmuizelaar
Attachment #373662 -
Flags: review?(joe)
Comment 4•16 years ago
|
||
Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables
r+ as long as we commit a reftest along with this fix.
Attachment #373662 -
Flags: review?(joe) → review+
Flags: wanted1.9.1?
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Priority: -- → P1
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 6•16 years ago
|
||
(reftest is in bug 489133)
Updated•16 years ago
|
Attachment #373662 -
Flags: approval1.9.1?
Comment 7•16 years ago
|
||
Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables
This patch now has tests, and is very low risk.
Comment 8•16 years ago
|
||
Comment on attachment 373662 [details] [diff] [review]
Fix generation of linear gamma input tables
a191=beltzner
Attachment #373662 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 9•16 years ago
|
||
Keywords: checkin-needed → fixed1.9.1
Comment 10•16 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre ID:20090507032833
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre ID:20090507034334
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•