Closed Bug 490103 Opened 16 years ago Closed 15 years ago

Clean up autoconfig CSS

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

Having gone through several iterations of UI, the autoconfig CSS has a fair number of selectors that don't select anything, and probably some that do select, but could use improvement.
Attached patch Cleanup on aisle 1 (obsolete) (deleted) — Splinter Review
Bet you wish now you'd taken the bug, so you could have had the minor tedium of writing it instead of the extreme tedium of having to stay awake clear through checking it :)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #403972 - Flags: review?(bwinton)
Two questions, while I build the Ubuntu and Windows versions: >+++ b/mail/themes/gnomestripe/mail/accountCreation.css >-vbox.settings { >- padding: 1em; >-} Should we also remove the class from mailnews/base/prefs/content/accountcreation/emailWizard.xul line 221: <groupbox id="settingsbox" class="settings"> ? >-vbox.initialSettings textbox { >- width: 280px; >-} Should we also remove the class from mailnews/base/prefs/content/accountcreation/emailWizard.xul line 147: <groupbox class="initialSettings"> ? Thanks, Blake.
Attached patch Cleanup on aisle 2 (deleted) — Splinter Review
Good call - switched initialSettings to an id in case a third-party theme needs it, dropped the class="settings".
Attachment #403972 - Attachment is obsolete: true
Attachment #404662 - Flags: review?(bwinton)
Attachment #403972 - Flags: review?(bwinton)
Comment on attachment 404662 [details] [diff] [review] Cleanup on aisle 2 Okay, I tested it on XP, OS X, and Ubuntu, and there were no layout changes caused by this, and the changes look good, so I say go for it. r=me.
Attachment #404662 - Flags: review?(bwinton) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: