Closed Bug 4912 Opened 26 years ago Closed 26 years ago

closing preferences when spawning window closed crashes app

Categories

(SeaMonkey :: UI Design, defect, P1)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cpratt, Assigned: danm.moz)

Details

to reproduce this: 1 launch apprunner 2 create a new browser window 3 in the new browser window, select edit preferences 4 wait for preferences to appear 5 close the new browser window 6 close the preferences window result: you crash. expected result: no crash.
Assignee: don → mcmullen
Priority: P3 → P1
Target Milestone: M5
Re-assigned to mcmullen@netscape.com; set target milestone to M5; and changed priority to P1. Yep, that crashes, allright. John, is this really fixable for M5?
How can you close the browser window when the prefs window is supposed to be modal? I note that somehow this is a really old bug. I also suspect that it doesn't happen any more. Will investigate.
I just checked, and indeed this is all sadly true. Reassigning to danm for a look (since he was kind enough to put in the modal dialog stuff - no good deed goes unpunished.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
This was a Windows-only problem. There's actually no problem closing the parent of one of our modal dialogs -- I've done it without repercussions -- the crash bug here must have something to do with code specific to this particular dialog. But still, the preferences dialog asks to be modal, so it seems fair that it could make assumptions about its parent remaining. This crash happens because the Windows modality code has actually been allowing the parent window to be brought in front of its modal dialog. So, modal dialogs brought up from the ToolkitCore and PrefsCore no longer allow this. The parent window can therefore no longer be closed while the prefs dialog is up, so this bug shouldn't be a problem any more.
this is what I encountered using the 1999042908 build on a win95 machine: 1. opened apprunner 2. selected the throbber to go to the home page 3. selected New Navigator window 4. from the new window, selected Edit | Preferences 5. selected the initial navigator window and clsoed it is this the appropriate functionality? I can do the same thing in 4.51.
Status: RESOLVED → VERIFIED
I'm marking this bug as verified since it works the same as 4.x
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.