Closed Bug 493074 Opened 16 years ago Closed 14 years ago

Investigate performance regression caused by bug 483672

Categories

(Core :: Security: CAPS, defect)

Product:
Core
Component:
Security: CAPS
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.1 --- ?

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attempt to fix the perf regression
(deleted), patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Attempt 2
(deleted), patch
Details | Diff | Splinter Review
Attachment #377514 - Flags: superreview?(jst)
Attachment #377514 - Flags: review?(jst)
Note that the patch here regresses bug 483672, comment 29.
Comment on attachment 377514 [details] [diff] [review] Attempt to fix the perf regression Let's give this a shot and see if it solves the perf problem.
Attachment #377514 - Flags: superreview?(jst)
Attachment #377514 - Flags: superreview+
Attachment #377514 - Flags: review?(jst)
Attachment #377514 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/6a7cb1bd5812
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Did this landing actually help with the perf regression? (And if it didn't, should this stay in, considering the additional regression mentioned in comment 2? Or does that regression not matter?)
The jury is still out on whether this actually fixed the perf regression. After this landed, the numbers bounced off the original value a couple of times. I'll attach a new patch to try to address the remainder. shaver, beltzner, jst and me decided to take the perf hit on 191 and try to address it (after verifying that the fix for it doesn't break anything) for a dot release.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Flags: wanted1.9.1.x?
Resolution: --- → FIXED
Attached patch Attempt 2 (deleted) — — Splinter Review
Attachment #379248 - Flags: superreview?(jst)
Attachment #379248 - Flags: review?(jst)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
status1.9.1: --- → ?
Flags: wanted1.9.1.x?
Aw yeah, compartments...
Status: REOPENED → RESOLVED
Closed: 16 years ago → 14 years ago
Resolution: --- → FIXED
Attachment #379248 - Flags: superreview?(jst)
Attachment #379248 - Flags: review?(jst)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: